Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753938AbcCIUdH (ORCPT ); Wed, 9 Mar 2016 15:33:07 -0500 Received: from mail-lb0-f194.google.com ([209.85.217.194]:33219 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934124AbcCIUcr (ORCPT ); Wed, 9 Mar 2016 15:32:47 -0500 MIME-Version: 1.0 In-Reply-To: <56E05612.702@nvidia.com> References: <1457529213-2581-1-git-send-email-jonathanh@nvidia.com> <56E05612.702@nvidia.com> Date: Wed, 9 Mar 2016 21:32:44 +0100 X-Google-Sender-Auth: GqgdswmlLFMyE1r-mGRdw5sCHk4 Message-ID: Subject: Re: [PATCH V2] PM / clk: Add support for obtaining clocks from device-tree From: "Rafael J. Wysocki" To: Jon Hunter Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Geert Uytterhoeven , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , linux-tegra@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 36 On Wed, Mar 9, 2016 at 5:57 PM, Jon Hunter wrote: > > On 09/03/16 14:04, Rafael J. Wysocki wrote: >> On Wed, Mar 9, 2016 at 2:13 PM, Jon Hunter wrote: >>> The PM clocks framework requires clients to pass either a con-id or a >>> valid clk pointer in order to add a clock to a device. Add a new >>> function of_pm_clk_add_clks() to allows device clocks to be retrieved >>> from device-tree and populated for a given device. Note that >>> of_clk_get_from_provider() is not defined if CONFIG_OF and >>> CONFIG_COMMON_CLK are not selected. Therefore, make of_pm_clk_add_clks() >>> dependent on these options. >>> >>> An optional function pointer may be passed to of_pm_clk_add_clks() that >>> can be used to filter the clocks that are added for a device when >>> calling of_pm_clk_add_clks(). >>> >>> In order to handle errors encountered when adding clocks from >>> device-tree, add a function pm_clk_remove_clk() to remove any clocks >>> (using a pointer to the clk structure) that have been added >>> successfully before the error occurred. >>> >>> Signed-off-by: Jon Hunter >>> --- >>> >>> Changes v1-v2: >>> - Added support for optional filter function as suggested by Geert U. >> >> I'd like to get an ACK on this from someone more familiar with the DT >> stuff than I am. > > No problem. Is Geert's ACK sufficient or is there someone else I should add? It would do. Thanks, Rafael