Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753995AbcCIU7l (ORCPT ); Wed, 9 Mar 2016 15:59:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:44292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbcCIU7c (ORCPT ); Wed, 9 Mar 2016 15:59:32 -0500 Date: Wed, 9 Mar 2016 21:59:30 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Petr Mladek cc: Josh Poimboeuf , Jessica Yu , Miroslav Benes , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Chris J Arges Subject: Re: [PATCH] livepatch: Fix the error message about unresolvable ambiguity In-Reply-To: <1457533259-6138-1-git-send-email-pmladek@suse.com> Message-ID: References: <1457533259-6138-1-git-send-email-pmladek@suse.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 18 On Wed, 9 Mar 2016, Petr Mladek wrote: > klp_find_callback() stops the search when sympos is not defined and > a second symbol of the same name is found. It means that the current > error message about the unresolvable ambiguity always prints "(2 matches)". > > Let's remove this information. The total number of occurrences is > not much helpful. The author of the patch still must put a non-trivial > effort into searching the right position in the object file. > > Signed-off-by: Petr Mladek I've fixed the grammar as suggested by Josh and applied to for-4.6/upstream. -- Jiri Kosina SUSE Labs