Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934216AbcCIVVu (ORCPT ); Wed, 9 Mar 2016 16:21:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55523 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932504AbcCIVVn (ORCPT ); Wed, 9 Mar 2016 16:21:43 -0500 Date: Wed, 9 Mar 2016 13:21:42 -0800 From: Andrew Morton To: Michal Hocko Cc: , Tetsuo Handa , David Rientjes , LKML , Michal Hocko , Johannes Weiner Subject: Re: [PATCH 2/2] oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix Message-Id: <20160309132142.80d0afbf0ae398df8e2adba8@linux-foundation.org> In-Reply-To: <1457442737-8915-3-git-send-email-mhocko@kernel.org> References: <1457442737-8915-1-git-send-email-mhocko@kernel.org> <1457442737-8915-3-git-send-email-mhocko@kernel.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2468 Lines: 76 On Tue, 8 Mar 2016 14:12:17 +0100 Michal Hocko wrote: > From: Michal Hocko > > fix a left over > > Tetsuo Handa > Signed-off-by: Michal Hocko > --- > mm/oom_kill.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 70fff7e3b1a7..b6228643367b 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -569,7 +569,7 @@ static int __init oom_init(void) > } > subsys_initcall(oom_init) > #else > -static void wake_oom_reaper(struct task_struct *mm) > +static void wake_oom_reaper(struct task_struct *tsk) > { > } > #endif Thanks. I found the below patch lying around but I didn't queue it properly. Is it legit? From: Johannes Weiner Subject: oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix When the OOM killer scans tasks and encounters a PF_EXITING one, it force-selects that one regardless of the score. Is there a possibility that the task might hang after it has set PF_EXITING? In that case the OOM killer should be able to move on to the next task. Frankly, I don't even know why we check for exiting tasks in the OOM killer. We've tried direct reclaim at least 15 times by the time we decide the system is OOM, there was plenty of time to exit and free memory; and a task might exit voluntarily right after we issue a kill. This is testing pure noise. Cc: Tetsuo Handa Cc: Michal Hocko Cc: Kirill A. Shutemov Cc: Mel Gorman Cc: David Rientjes Cc: Oleg Nesterov Cc: Hugh Dickins Cc: Andrea Argangeli Cc: Rik van Riel Cc: Sasha Levin Signed-off-by: Andrew Morton --- mm/oom_kill.c | 3 --- 1 file changed, 3 deletions(-) diff -puN mm/oom_kill.c~oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix mm/oom_kill.c --- a/mm/oom_kill.c~oom-clear-tif_memdie-after-oom_reaper-managed-to-unmap-the-address-space-fix +++ a/mm/oom_kill.c @@ -292,9 +292,6 @@ enum oom_scan_t oom_scan_process_thread( if (oom_task_origin(task)) return OOM_SCAN_SELECT; - if (task_will_free_mem(task) && !is_sysrq_oom(oc)) - return OOM_SCAN_ABORT; - return OOM_SCAN_OK; } _