Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934234AbcCIVWb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Mar 2016 16:22:31 -0500
Received: from mail-ob0-f173.google.com ([209.85.214.173]:33539 "EHLO
	mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933634AbcCIVWZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Mar 2016 16:22:25 -0500
MIME-Version: 1.0
In-Reply-To: <20160308064024.GB16568@pd.tnic>
References: <cover.1457243356.git.luto@kernel.org> <5a51d09b68d75fefe2c648ab869367f03b951ffa.1457243356.git.luto@kernel.org>
 <20160308064024.GB16568@pd.tnic>
From: Andy Lutomirski <luto@amacapital.net>
Date: Wed, 9 Mar 2016 13:22:05 -0800
Message-ID: <CALCETrUB6xtAiOaS7rxqbaLdWrr91Nsu8q7Mz8GmegO4=GpBGw@mail.gmail.com>
Subject: Re: [PATCH v2 10/10] x86/entry/32: Add and check a stack canary for
 the SYSENTER stack
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Brian Gerst <brgerst@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 459
Lines: 16

On Mon, Mar 7, 2016 at 10:40 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Sat, Mar 05, 2016 at 09:52:23PM -0800, Andy Lutomirski wrote:
>
> <--- ?
>
> So all patches before are nice and verbose in explaining what they do.
> Where did the commit message of this one disappear?
>
> :-)
>
> Or is it that obvious that we should have a stack canary? How about some
> text *why* we need it?

I'll send a v3 with this and the other changes you requested.

--Andy