Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934645AbcCJAR1 (ORCPT ); Wed, 9 Mar 2016 19:17:27 -0500 Received: from mga01.intel.com ([192.55.52.88]:50038 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933537AbcCJARV (ORCPT ); Wed, 9 Mar 2016 19:17:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,313,1455004800"; d="scan'208";a="933437570" Date: Wed, 9 Mar 2016 16:18:00 -0800 (PST) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group In-Reply-To: <20160307230442.GU6344@twins.programming.kicks-ass.net> Message-ID: References: <1456876108-28770-1-git-send-email-vikas.shivappa@linux.intel.com> <1456876108-28770-2-git-send-email-vikas.shivappa@linux.intel.com> <20160307230442.GU6344@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 24 On Mon, 7 Mar 2016, Peter Zijlstra wrote: > On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote: >> --- a/include/linux/perf_event.h >> +++ b/include/linux/perf_event.h >> @@ -121,6 +121,7 @@ struct hw_perf_event { >> struct { /* intel_cqm */ >> int cqm_state; >> u32 cqm_rmid; >> + bool is_group_event; >> struct list_head cqm_events_entry; >> struct list_head cqm_groups_entry; >> struct list_head cqm_group_entry; > > Please, no 'bool' in structures. Will fix.. thanks, vikas >