Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934498AbcCJArn (ORCPT ); Wed, 9 Mar 2016 19:47:43 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:55739 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcCJArf (ORCPT ); Wed, 9 Mar 2016 19:47:35 -0500 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: imunsie@au1.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 From: Ian Munsie To: Frederic Barrat Cc: Michael Ellerman , linux-kernel , Matt Ochs , Manoj Kumar , linuxppc-dev , Michael Neuling Subject: Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events In-reply-to: <56DFEC78.9050704@linux.vnet.ibm.com> References: <1457401715-26435-1-git-send-email-imunsie@au.ibm.com> <56DFEC78.9050704@linux.vnet.ibm.com> Date: Thu, 10 Mar 2016 11:46:01 +1100 Message-Id: <1457570734-sup-641@delenn.ozlabs.ibm.com> User-Agent: Sup/0.20.0 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031000-0029-0000-0000-000044388B0F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 400 Lines: 8 Excerpts from Frederic Barrat's message of 2016-03-09 20:27:20 +1100: > So on afu_read(), we may call afu_driver_ops->event_pending() twice > before calling afu_driver_ops->deliver_event(). Actually, in the > (likely) scenario where there's only an afu_driver event pending, we > *will* call afu_driver_ops->event_pending() twice. Wouldn't it make > sense to cache it then? Yep, will change it.