Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934597AbcCJB1h (ORCPT ); Wed, 9 Mar 2016 20:27:37 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:36630 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932503AbcCJB13 (ORCPT ); Wed, 9 Mar 2016 20:27:29 -0500 X-IBM-Helo: d23dlp02.au.ibm.com X-IBM-MailFrom: imunsie@au1.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 From: Ian Munsie To: Frederic Barrat Cc: Michael Ellerman , linux-kernel , Matt Ochs , Manoj Kumar , linuxppc-dev , Michael Neuling Subject: Re: [PATCH v3 1/2] cxl: Add mechanism for delivering AFU driver specific events In-reply-to: <56DFEC78.9050704@linux.vnet.ibm.com> References: <1457401715-26435-1-git-send-email-imunsie@au.ibm.com> <56DFEC78.9050704@linux.vnet.ibm.com> Date: Thu, 10 Mar 2016 12:26:22 +1100 Message-Id: <1457573125-sup-1934@delenn.ozlabs.ibm.com> User-Agent: Sup/0.20.0 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031001-0029-0000-0000-00004438994F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 366 Lines: 11 Excerpts from Frederic Barrat's message of 2016-03-09 20:27:20 +1100: > It would also avoid entering > WARN(1, "afu_read must be buggy\n"); > if the driver changes its mind between the 2 calls :-) Honestly, it had better not - that would be a gross violation of the poll & read semantics and the kind of thing that leads to application hangs. Cheers, -Ian