Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935019AbcCJDTG (ORCPT ); Wed, 9 Mar 2016 22:19:06 -0500 Received: from forward.webhostbox.net ([162.251.85.56]:49994 "EHLO forward.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934596AbcCJDTB (ORCPT ); Wed, 9 Mar 2016 22:19:01 -0500 Subject: Re: [PATCH 01/13] hwmon: convert lm75 to use devm_thermal_zone_of_sensor_register To: Eduardo Valentin , Rui Zhang References: <1457559336-17652-1-git-send-email-edubezval@gmail.com> <1457559336-17652-2-git-send-email-edubezval@gmail.com> Cc: Linux PM , LKML , lm-sensors@lm-sensors.org, Jean Delvare From: Guenter Roeck Message-ID: <56E0E7A0.2080202@roeck-us.net> Date: Wed, 9 Mar 2016 19:18:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457559336-17652-2-git-send-email-edubezval@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=MpLykzue c=1 sm=1 tr=0 a=9TTQYYGGY7a1eFc7Vblcuw==:117 a=2cfIYNtKkjgZNaOwnGXpGw==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=N659UExz7-8A:10 a=7OsogOcEt9IA:10 a=wqjDAO3sHL17RyNg200A:9 a=pILNOxqGKmIA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1877 Lines: 53 On 03/09/2016 01:35 PM, Eduardo Valentin wrote: > This changes the driver to use the devm_ version > of thermal_zone_of_sensor_register and cleans > up the local points and unregister calls. > > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: lm-sensors@lm-sensors.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin Acked-by: Guenter Roeck > --- > drivers/hwmon/lm75.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index 0addc84..69166ab 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -77,7 +77,6 @@ static const u8 LM75_REG_TEMP[3] = { > struct lm75_data { > struct i2c_client *client; > struct device *hwmon_dev; > - struct thermal_zone_device *tz; > struct mutex update_lock; > u8 orig_conf; > u8 resolution; /* In bits, between 9 and 12 */ > @@ -306,11 +305,9 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id) > if (IS_ERR(data->hwmon_dev)) > return PTR_ERR(data->hwmon_dev); > > - data->tz = thermal_zone_of_sensor_register(data->hwmon_dev, 0, > - data->hwmon_dev, > - &lm75_of_thermal_ops); > - if (IS_ERR(data->tz)) > - data->tz = NULL; > + devm_thermal_zone_of_sensor_register(data->hwmon_dev, 0, > + data->hwmon_dev, > + &lm75_of_thermal_ops); > > dev_info(dev, "%s: sensor '%s'\n", > dev_name(data->hwmon_dev), client->name); > @@ -322,7 +319,6 @@ static int lm75_remove(struct i2c_client *client) > { > struct lm75_data *data = i2c_get_clientdata(client); > > - thermal_zone_of_sensor_unregister(data->hwmon_dev, data->tz); > hwmon_device_unregister(data->hwmon_dev); > lm75_write_value(client, LM75_REG_CONF, data->orig_conf); > return 0; >