Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935034AbcCJD2O (ORCPT ); Wed, 9 Mar 2016 22:28:14 -0500 Received: from ozlabs.org ([103.22.144.67]:47053 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933191AbcCJD2F (ORCPT ); Wed, 9 Mar 2016 22:28:05 -0500 From: Rusty Russell To: Jessica Yu , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Petr Mladek Cc: Steven Rostedt , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu Subject: Re: [PATCH 0/3] Livepatch module notifier cleanup In-Reply-To: <1457561637-24770-1-git-send-email-jeyu@redhat.com> References: <1457561637-24770-1-git-send-email-jeyu@redhat.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 10 Mar 2016 13:57:32 +1030 Message-ID: <878u1rko63.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 38 Jessica Yu writes: > These are the remaining 3 patches that came from the original ftrace/livepatch > module notifier patchset found here: https://lkml.org/lkml/2016/2/8/1180 Please add my Acked-by to the first and third. Cheers, Rusty. > Basically, the patchset does a bit of module.c cleanup (patch 1 and 2) in > preparation for the klp_module_{coming,going} calls (patch 3). We decided > to stop relying on the module notifier callchain in favor of hard-coding > the appropriate livepatch function calls that handle coming and going > modules. Hard-coding these calls will guarantee that ftrace and livepatch > exit/initialization routines are called in the correct order without > relying on module notifiers. > > The patches should be nearly exactly the same as those from the previous > discussion, except in patch 3 I've added back the #if IS_ENABLED(CONFIG_LIVEPATCH) > guard in livepatch.h, and in patch 2 I decided that it might be safer to > change mod->state with the module mutex held. > > Patches based on linux-next. > > Previous discussion found here: https://lkml.org/lkml/2016/2/8/1180 > > Jessica Yu (3): > modules: split part of complete_formation() into prepare_coming_module() > modules: set mod->state to GOING before going notifiers are called > livepatch/module: remove livepatch module notifier > > include/linux/livepatch.h | 13 +++++ > kernel/livepatch/core.c | 145 ++++++++++++++++++++++------------------------ > kernel/module.c | 39 ++++++++++--- > 3 files changed, 113 insertions(+), 84 deletions(-) > > -- > 2.4.3