Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754657AbcCJJfJ (ORCPT ); Thu, 10 Mar 2016 04:35:09 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37128 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbcCJJfG (ORCPT ); Thu, 10 Mar 2016 04:35:06 -0500 Date: Thu, 10 Mar 2016 10:34:38 +0100 From: Sascha Hauer To: Eduardo Valentin Cc: Rui Zhang , Linux PM , LKML , lm-sensors@lm-sensors.org, Dmitry Torokhov , Maxime Ripard , Chen-Yu Tsai , Hans de Goede , Lukasz Majewski , Heiko Stuebner , Jens Thiele , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/13] input: convert sun4i-ts to use devm_thermal_zone_of_sensor_register Message-ID: <20160310093438.GL30994@pengutronix.de> References: <1457559336-17652-1-git-send-email-edubezval@gmail.com> <1457559336-17652-6-git-send-email-edubezval@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457559336-17652-6-git-send-email-edubezval@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:33:18 up 2 days, 12:32, 47 users, load average: 0.03, 0.09, 0.13 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 55 On Wed, Mar 09, 2016 at 01:35:27PM -0800, Eduardo Valentin wrote: > This changes the driver to use the devm_ version > of thermal_zone_of_sensor_register and cleans > up the local points and unregister calls. > > Cc: Dmitry Torokhov > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Hans de Goede > Cc: Zhang Rui > Cc: Lukasz Majewski > Cc: Heiko Stuebner > Cc: Sascha Hauer > Cc: Jens Thiele > Cc: linux-input@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > drivers/input/touchscreen/sun4i-ts.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c > index 4857943..d07dd29 100644 > --- a/drivers/input/touchscreen/sun4i-ts.c > +++ b/drivers/input/touchscreen/sun4i-ts.c > @@ -115,7 +115,6 @@ > struct sun4i_ts_data { > struct device *dev; > struct input_dev *input; > - struct thermal_zone_device *tz; > void __iomem *base; > unsigned int irq; > bool ignore_fifo_data; > @@ -366,10 +365,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) > if (IS_ERR(hwmon)) > return PTR_ERR(hwmon); > > - ts->tz = thermal_zone_of_sensor_register(ts->dev, 0, ts, > - &sun4i_ts_tz_ops); > - if (IS_ERR(ts->tz)) > - ts->tz = NULL; > + devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, &sun4i_ts_tz_ops); Shouldn't we check the return value? There are a few possibilities for thermal_zone_of_sensor_register to fail. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |