Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965532AbcCJK6M (ORCPT ); Thu, 10 Mar 2016 05:58:12 -0500 Received: from mail-lb0-f196.google.com ([209.85.217.196]:35482 "EHLO mail-lb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935231AbcCJK5p (ORCPT ); Thu, 10 Mar 2016 05:57:45 -0500 From: Alexander Kochetkov To: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Caesar Wang , Doug Anderson , linux-rockchip@lists.infradead.org, Heiko Stuebner , Alexander Kochetkov Subject: [PATCH 2/3 v2] dmaengine: pl330: don't emit code for one iteration loop Date: Thu, 10 Mar 2016 13:57:35 +0300 Message-Id: <1457607456-30458-2-git-send-email-al.kochet@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1457607456-30458-1-git-send-email-al.kochet@gmail.com> References: <1455798674-10186-1-git-send-email-al.kochet@gmail.com> <1457607456-30458-1-git-send-email-al.kochet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 55 The patch remove one iteration outer loop in the _loop(). Removing loop saves 4 bytes of MicroCode buffer. DMALP_0 0 ... DMALPENDA_0 bjmpto_9 Signed-off-by: Alexander Kochetkov Reviewed-by: Caesar Wang --- drivers/dma/pl330.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 4abbc71..b080d70 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -1258,7 +1258,7 @@ static inline int _loop(unsigned dry_run, u8 buf[], lpend.bjump = 0; szlpend = _emit_LPEND(1, buf, &lpend); - if (lcnt0) { + if (lcnt0 > 1) { szlp *= 2; szlpend *= 2; } @@ -1274,7 +1274,7 @@ static inline int _loop(unsigned dry_run, u8 buf[], off = 0; - if (lcnt0) { + if (lcnt0 > 1) { off += _emit_LP(dry_run, &buf[off], 0, lcnt0); ljmp0 = off; } @@ -1290,7 +1290,7 @@ static inline int _loop(unsigned dry_run, u8 buf[], lpend.bjump = off - ljmp1; off += _emit_LPEND(dry_run, &buf[off], &lpend); - if (lcnt0) { + if (lcnt0 > 1) { lpend.cond = ALWAYS; lpend.forever = false; lpend.loop = 0; @@ -1299,7 +1299,7 @@ static inline int _loop(unsigned dry_run, u8 buf[], } *bursts = lcnt1 * cyc; - if (lcnt0) + if (lcnt0 > 1) *bursts *= lcnt0; return off; -- 1.7.9.5