Subject: Re: [PATCH 0/2] KVM: x86: disable MPX if host did not enable MPX
 XSAVE features
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>
References: <1457437481-65784-1-git-send-email-pbonzini@redhat.com>
 <56E1686F.1060200@linux.intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56E168FB.3080509@redhat.com>
Date: Thu, 10 Mar 2016 13:30:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56E1686F.1060200@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 599
Lines: 21


On 10/03/2016 13:28, Xiao Guangrong wrote:
> 
>> Patch 1 ensures that all aspects of MPX are disabled when eager FPU
>> is disabled on the host.  Patch 2 is just a cleanup.
> 
> It looks good to me.
> 
> Reviewed-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>

Thanks very much!

> Now, more and more features depend on eger xsave, e.g, fpu, mpx and
> protection-key, maybe it is the time to rename eager-fpu to eager-xsave?

Yeah, that could be possible.  You can propose it to Ingo Molnar (CCed).
 If you change it in the general purpose kernel code, KVM will of course
follow suit.

Paolo