Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751179AbcCJMwI (ORCPT ); Thu, 10 Mar 2016 07:52:08 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:38954 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbcCJMwE (ORCPT ); Thu, 10 Mar 2016 07:52:04 -0500 Subject: Re: [PATCH v3 2/6] ARM: dts: am437x/am33xx: Fix GPMC dma properties To: Franklin S Cooper Jr , , , , , , , , References: <1457582861-20619-1-git-send-email-fcooper@ti.com> <1457582861-20619-3-git-send-email-fcooper@ti.com> From: Roger Quadros Message-ID: <56E16DBF.40409@ti.com> Date: Thu, 10 Mar 2016 14:51:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457582861-20619-3-git-send-email-fcooper@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 57 On 10/03/16 06:07, Franklin S Cooper Jr wrote: > Recent patch series that updated the eDMA driver also updated the eDMA > bindings. > > The following patches forgot to update the DMA bindings for the GPMC node. > ARM: DTS: am33xx: Use the new DT bindings for the eDMA3 > ARM: DTS: am437x: Use the new DT bindings for the eDMA3 Instead of mentioning the patch subject here use the Fixes: tag. > > This patch corrects this so NAND with DMA prefetch can work. > > Signed-off-by: Franklin S Cooper Jr Please split this patch in to am33xx.dtsi and am4372.dtsi > --- > arch/arm/boot/dts/am33xx.dtsi | 2 +- > arch/arm/boot/dts/am4372.dtsi | 2 +- what about dm816x.dtsi and dm814x.dtsi? I suppose sdma based SoCs are not affected like this right? cheers, -roger > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 1fafaad..97471d6 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -860,7 +860,7 @@ > ti,no-idle-on-init; > reg = <0x50000000 0x2000>; > interrupts = <100>; > - dmas = <&edma 52>; > + dmas = <&edma 52 0>; > dma-names = "rxtx"; > gpmc,num-cs = <7>; > gpmc,num-waitpins = <2>; > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 92068fb..2878b04 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -884,7 +884,7 @@ > gpmc: gpmc@50000000 { > compatible = "ti,am3352-gpmc"; > ti,hwmods = "gpmc"; > - dmas = <&edma 52>; > + dmas = <&edma 52 0>; > dma-names = "rxtx"; > clocks = <&l3s_gclk>; > clock-names = "fck"; >