Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbcCJNUK (ORCPT ); Thu, 10 Mar 2016 08:20:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55236 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbcCJNUC (ORCPT ); Thu, 10 Mar 2016 08:20:02 -0500 Subject: Re: [PATCH 05/13] input: convert sun4i-ts to use devm_thermal_zone_of_sensor_register To: Sascha Hauer , Eduardo Valentin References: <1457559336-17652-1-git-send-email-edubezval@gmail.com> <1457559336-17652-6-git-send-email-edubezval@gmail.com> <20160310093438.GL30994@pengutronix.de> Cc: Rui Zhang , Linux PM , LKML , lm-sensors@lm-sensors.org, Dmitry Torokhov , Maxime Ripard , Chen-Yu Tsai , Lukasz Majewski , Heiko Stuebner , Jens Thiele , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Hans de Goede Message-ID: <56E17475.8010506@redhat.com> Date: Thu, 10 Mar 2016 14:19:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160310093438.GL30994@pengutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2170 Lines: 63 Hi, On 10-03-16 10:34, Sascha Hauer wrote: > On Wed, Mar 09, 2016 at 01:35:27PM -0800, Eduardo Valentin wrote: >> This changes the driver to use the devm_ version >> of thermal_zone_of_sensor_register and cleans >> up the local points and unregister calls. >> >> Cc: Dmitry Torokhov >> Cc: Maxime Ripard >> Cc: Chen-Yu Tsai >> Cc: Hans de Goede >> Cc: Zhang Rui >> Cc: Lukasz Majewski >> Cc: Heiko Stuebner >> Cc: Sascha Hauer >> Cc: Jens Thiele >> Cc: linux-input@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> drivers/input/touchscreen/sun4i-ts.c | 9 +-------- >> 1 file changed, 1 insertion(+), 8 deletions(-) >> >> diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c >> index 4857943..d07dd29 100644 >> --- a/drivers/input/touchscreen/sun4i-ts.c >> +++ b/drivers/input/touchscreen/sun4i-ts.c >> @@ -115,7 +115,6 @@ >> struct sun4i_ts_data { >> struct device *dev; >> struct input_dev *input; >> - struct thermal_zone_device *tz; >> void __iomem *base; >> unsigned int irq; >> bool ignore_fifo_data; >> @@ -366,10 +365,7 @@ static int sun4i_ts_probe(struct platform_device *pdev) >> if (IS_ERR(hwmon)) >> return PTR_ERR(hwmon); >> >> - ts->tz = thermal_zone_of_sensor_register(ts->dev, 0, ts, >> - &sun4i_ts_tz_ops); >> - if (IS_ERR(ts->tz)) >> - ts->tz = NULL; >> + devm_thermal_zone_of_sensor_register(ts->dev, 0, ts, &sun4i_ts_tz_ops); > > Shouldn't we check the return value? There are a few possibilities for > thermal_zone_of_sensor_register to fail. Note thee old code also was not checking this, it was simply continuing without having registered a tz-sensor. I guess we could log an error in that case, but that should be done in a seperate follow-up patch. The current patch looks good to me: Acked-by: Hans de Goede Regards, Hans