Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbcCJOBZ (ORCPT ); Thu, 10 Mar 2016 09:01:25 -0500 Received: from mailrelay7.public.one.com ([91.198.169.215]:51239 "EHLO mailrelay7.public.one.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbcCJOBV (ORCPT ); Thu, 10 Mar 2016 09:01:21 -0500 X-Greylist: delayed 964 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Mar 2016 09:01:20 EST X-HalOne-Cookie: c38053387c588a3333d695266c4694fe83b2caf6 X-HalOne-ID: 50ed8a1c-e6c6-11e5-bb5b-b82a72cffc46 Subject: Re: [PATCH] Input: Do not add SYN_REPORT in between a single packet data To: Dmitry Torokhov , Aniroop Mathur References: <1457372672-884-1-git-send-email-a.mathur@samsung.com> Cc: "linux-input@vger.kernel.org" , lkml , Aniroop Mathur From: Henrik Rydberg Message-ID: <56E17A73.8090901@bitmath.org> Date: Thu, 10 Mar 2016 14:45:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 29 Hi Dmitry, >> diff --git a/drivers/input/input.c b/drivers/input/input.c >> index 8806059..262ef77 100644 >> --- a/drivers/input/input.c >> +++ b/drivers/input/input.c >> @@ -401,8 +401,7 @@ static void input_handle_event(struct input_dev *dev, >> if (dev->num_vals >= 2) >> input_pass_values(dev, dev->vals, dev->num_vals); >> dev->num_vals = 0; >> - } else if (dev->num_vals >= dev->max_vals - 2) { >> - dev->vals[dev->num_vals++] = input_value_sync; >> + } else if (dev->num_vals >= dev->max_vals - 1) { >> input_pass_values(dev, dev->vals, dev->num_vals); >> dev->num_vals = 0; >> } > > This makes sense to me. Henrik? I went through the commits that made these changes, and I cannot see any strong reason to keep it. However, this code path only triggers if no SYN events are seen, as in a driver that fails to emit them and consequently fills up the buffer. In other words, this change would only affect a device that is already, to some degree, broken. So, the question to Aniroop is: do you see this problem in practise, and in that case, for what driver? Henrik