Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbcCJOEb (ORCPT ); Thu, 10 Mar 2016 09:04:31 -0500 Received: from mga03.intel.com ([134.134.136.65]:57649 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcCJOEY (ORCPT ); Thu, 10 Mar 2016 09:04:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="920957508" Subject: Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1457437538-65867-1-git-send-email-pbonzini@redhat.com> <1457437538-65867-3-git-send-email-pbonzini@redhat.com> Cc: huaitong.han@intel.com From: Xiao Guangrong Message-ID: <56E17ECB.1000107@linux.intel.com> Date: Thu, 10 Mar 2016 22:03:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457437538-65867-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 545 Lines: 15 On 03/08/2016 07:45 PM, Paolo Bonzini wrote: > Intel's new PKU extension introduces a bit of the page fault error code > that must be dynamically computed after the PTE lookup (unlike I/D, U/S > and W/R). To ease this, these two patches make permission_fault return > the page fault error code. > > Right now it only adds the P bit to the input parameter "pfec", but PKU > can change that. Yep, i got the same idea when i reviewed the pkey patchset. This patch looks good to me. Reviewed-by: Xiao Guangrong