Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbcCJOFL (ORCPT ); Thu, 10 Mar 2016 09:05:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49821 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbcCJOFC (ORCPT ); Thu, 10 Mar 2016 09:05:02 -0500 Subject: Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault To: Xiao Guangrong , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1457437538-65867-1-git-send-email-pbonzini@redhat.com> <1457437538-65867-3-git-send-email-pbonzini@redhat.com> <56E17ECB.1000107@linux.intel.com> Cc: huaitong.han@intel.com From: Paolo Bonzini Message-ID: <56E17F0A.7060608@redhat.com> Date: Thu, 10 Mar 2016 15:04:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E17ECB.1000107@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 23 On 10/03/2016 15:03, Xiao Guangrong wrote: > > > On 03/08/2016 07:45 PM, Paolo Bonzini wrote: >> Intel's new PKU extension introduces a bit of the page fault error code >> that must be dynamically computed after the PTE lookup (unlike I/D, U/S >> and W/R). To ease this, these two patches make permission_fault return >> the page fault error code. >> >> Right now it only adds the P bit to the input parameter "pfec", but PKU >> can change that. > > Yep, i got the same idea when i reviewed the pkey patchset. This patch > looks good to me. > > Reviewed-by: Xiao Guangrong Great, feel free to pick it up in the pkey patchset. I'm answering to 1/2 now. Paolo