Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbcCJPgh (ORCPT ); Thu, 10 Mar 2016 10:36:37 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51240 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbcCJPga (ORCPT ); Thu, 10 Mar 2016 10:36:30 -0500 Message-ID: In-Reply-To: References: <1457440568-13084-1-git-send-email-ygardi@codeaurora.org> <1457440568-13084-7-git-send-email-ygardi@codeaurora.org> Date: Thu, 10 Mar 2016 15:36:28 -0000 Subject: Re: [PATCH v7 06/17] scsi: ufs: separate device and host quirks From: ygardi@codeaurora.org To: "Martin K. Petersen" Cc: "Yaniv Gardi" , james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, "Raviv Shvili" , "Vinayak Holikatti" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 32 Martin, the only way i can avoid the circular dependency is to move the routines from ufs_quirks.c into ufshcd.c. i will upload V8 soon thanks, Yaniv >>>>>> "Yaniv" == Yaniv Gardi writes: > > Yaniv> Currently we use the host quirks mechanism in order to handle > Yaniv> both device and host controller quirks. In order to support > Yaniv> various of UFS devices we should separate handling the device > Yaniv> quirks from the host controller's. > > This patch causes a circular dependency: > > depmod: ERROR: Cycle detected: ufshcd -> ufs_quirks -> ufshcd > > Please fix! > > -- > Martin K. Petersen Oracle Linux Engineering > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >