Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbcCJPrx (ORCPT ); Thu, 10 Mar 2016 10:47:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:15036 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcCJPrs (ORCPT ); Thu, 10 Mar 2016 10:47:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="921019163" Subject: Re: [PATCH] KVM: Remove redundant smp_mb() in the kvm_mmu_commit_zap_page() To: Paolo Bonzini , Lan Tianyu , Thomas Gleixner References: <1457055312-27067-1-git-send-email-tianyu.lan@intel.com> <56D9354E.9040908@intel.com> <56D94BFE.1080406@redhat.com> <56DE8F1A.9000401@intel.com> <56DEEF69.20208@redhat.com> <56E1875E.8060007@linux.intel.com> <56E19224.9090906@redhat.com> <56E1933E.20909@redhat.com> Cc: gleb@kernel.org, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Xiao Guangrong Message-ID: <56E196AC.4030103@linux.intel.com> Date: Thu, 10 Mar 2016 23:45:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E1933E.20909@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 281 Lines: 12 On 03/10/2016 11:31 PM, Paolo Bonzini wrote: > > > On 10/03/2016 16:26, Paolo Bonzini wrote: >> Compared to smp_load_acquire(), smp_mb() adds an ordering between stores >> and loads. > > Here, the ordering is load-store, hence... Yes, this is why i put smp_mb() in the code. :)