Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754602AbcCJRcg (ORCPT ); Thu, 10 Mar 2016 12:32:36 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:59006 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754267AbcCJRcW (ORCPT ); Thu, 10 Mar 2016 12:32:22 -0500 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: stefanb@linux.vnet.ibm.com X-IBM-RcptTo: linux-api@vger.kernel.org;linux-doc@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 08/11] tpm: Driver for supporting multiple emulated TPMs To: Jarkko Sakkinen References: <1457545170-30120-1-git-send-email-stefanb@linux.vnet.ibm.com> <1457545170-30120-9-git-send-email-stefanb@linux.vnet.ibm.com> <20160310163915.GA4863@intel.com> Cc: tpmdd-devel@lists.sourceforge.net, jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-api@vger.kernel.org From: Stefan Berger Message-ID: <56E1AF9F.3010409@linux.vnet.ibm.com> Date: Thu, 10 Mar 2016 12:32:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160310163915.GA4863@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031017-0025-0000-0000-00002259DC35 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 420 Lines: 15 On 03/10/2016 11:39 AM, Jarkko Sakkinen wrote: > +/* above flags */ > +#define VTPM_FLAG_TPM2 1 /* emulator is TPM 2 */ > + > +/* all supported flags */ > +#define VTPM_FLAGS_ALL (VTPM_FLAG_TPM2) > + > +#define VTPM_TPM 0xa0 > + > +#define VTPM_NEW_DEV _IOW(VTPM_TPM, 0x00, struct vtpm_new_dev) > I'd rather use VTPM_IOC_NEW_DEV. What about the name of the structure ? vtpm_ioc_new_dev? Stefan