Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754951AbcCJScO (ORCPT ); Thu, 10 Mar 2016 13:32:14 -0500 Received: from torg.zytor.com ([198.137.202.12]:48056 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754834AbcCJScM (ORCPT ); Thu, 10 Mar 2016 13:32:12 -0500 Date: Thu, 10 Mar 2016 10:31:00 -0800 From: tip-bot for Jianyu Zhan Message-ID: Cc: torvalds@linux-foundation.org, jbeulich@suse.com, peterz@infradead.org, bp@alien8.de, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, dvlasenk@redhat.com, nasa4836@gmail.com, brgerst@gmail.com, luto@amacapital.net, hpa@zytor.com Reply-To: jbeulich@suse.com, torvalds@linux-foundation.org, hpa@zytor.com, luto@amacapital.net, brgerst@gmail.com, dvlasenk@redhat.com, nasa4836@gmail.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, bp@alien8.de, peterz@infradead.org In-Reply-To: <1457612398-4568-1-git-send-email-nasa4836@gmail.com> References: <1457612398-4568-1-git-send-email-nasa4836@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/asm] x86/entry/traps: Show unhandled signal for i386 in do_trap() Git-Commit-ID: 10ee73865e9e4705ba8b3f4d6149e8e68d902bb7 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2474 Lines: 65 Commit-ID: 10ee73865e9e4705ba8b3f4d6149e8e68d902bb7 Gitweb: http://git.kernel.org/tip/10ee73865e9e4705ba8b3f4d6149e8e68d902bb7 Author: Jianyu Zhan AuthorDate: Thu, 10 Mar 2016 20:19:58 +0800 Committer: Ingo Molnar CommitDate: Thu, 10 Mar 2016 18:37:25 +0100 x86/entry/traps: Show unhandled signal for i386 in do_trap() Commit abd4f7505baf ("x86: i386-show-unhandled-signals-v3") did turn on the showing-unhandled-signal behaviour for i386 for some exception handlers, but for no reason do_trap() is left out (my naive guess is because turning it on for do_trap() would be too noisy since do_trap() is shared by several exceptions). And since the same commit make "show_unhandled_signals" a debug tunable(in /proc/sys/debug/exception-trace), and x86 by default turning it on. So it would be strange for i386 users who turing it on manually and expect seeing the unhandled signal output in log, but nothing. This patch turns it on for i386 in do_trap() as well. Signed-off-by: Jianyu Zhan Reviewed-by: Jan Beulich Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: bp@suse.de Cc: dave.hansen@linux.intel.com Cc: heukelum@fastmail.fm Cc: jbeulich@novell.com Cc: jdike@addtoit.com Cc: joe@perches.com Cc: luto@kernel.org Link: http://lkml.kernel.org/r/1457612398-4568-1-git-send-email-nasa4836@gmail.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/traps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 5fae2d8..1baf081 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -248,7 +248,6 @@ do_trap(int trapnr, int signr, char *str, struct pt_regs *regs, tsk->thread.error_code = error_code; tsk->thread.trap_nr = trapnr; -#ifdef CONFIG_X86_64 if (show_unhandled_signals && unhandled_signal(tsk, signr) && printk_ratelimit()) { pr_info("%s[%d] trap %s ip:%lx sp:%lx error:%lx", @@ -257,7 +256,6 @@ do_trap(int trapnr, int signr, char *str, struct pt_regs *regs, print_vma_addr(" in ", regs->ip); pr_cont("\n"); } -#endif force_sig_info(signr, info ?: SEND_SIG_PRIV, tsk); }