Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754948AbcCJTsY (ORCPT ); Thu, 10 Mar 2016 14:48:24 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:50604 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbcCJTsO (ORCPT ); Thu, 10 Mar 2016 14:48:14 -0500 Date: Thu, 10 Mar 2016 14:48:12 -0500 (EST) Message-Id: <20160310.144812.2252397711464239518.davem@davemloft.net> To: sunil.kovvuri@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sgoutham@cavium.com, robert.richter@caviumnetworks.com Subject: Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk From: David Miller In-Reply-To: References: <20160310.124450.278421705870462421.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Mar 2016 11:48:14 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 423 Lines: 11 From: Sunil Kovvuri Date: Thu, 10 Mar 2016 23:57:48 +0530 > Difference between NIU driver and this patch is there it's > calculate split count, increment page count and then divide page into > buffers. Here it's divide page into buffers, have a counter which increments > at every split and then at the end do a atomic increment of page->_count. > > Any issue with this approach ? I guess not.