Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932192AbcCJUbr (ORCPT ); Thu, 10 Mar 2016 15:31:47 -0500 Received: from mail-yk0-f171.google.com ([209.85.160.171]:36399 "EHLO mail-yk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbcCJUbo (ORCPT ); Thu, 10 Mar 2016 15:31:44 -0500 MIME-Version: 1.0 In-Reply-To: <1457077474-124064-4-git-send-email-qiujiang@huawei.com> References: <1457077474-124064-1-git-send-email-qiujiang@huawei.com> <1457077474-124064-4-git-send-email-qiujiang@huawei.com> Date: Thu, 10 Mar 2016 22:31:43 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] gpio: designware: add gpio-signaled acpi event support From: Andy Shevchenko To: qiujiang Cc: Linus Walleij , Alexandre Courbot , Mika Westerberg , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , linuxarm@huawei.com, haifeng.wei@huawei.com, charles.chenxin@huawei.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 59 On Fri, Mar 4, 2016 at 9:44 AM, qiujiang wrote: > This patch adds the support for the gpio-signaled acpi event. > This is used for power button on hisilicon D02 board, which > is an arm64 platform. > > To support this function, _AEI and _Exx objects must be > defined in the corresponding GPIO device as follows: > > Name (_AEI, ResourceTemplate () { > GpioInt(Edge, ActiveLow, ExclusiveAndWake, PullUp, > , " \\_SB.GPI0") {8} > }) > Method (_E08, 0x0, NotSerialized) { > Notify (\_SB.PWRB, 0x80) > } > > Acked-by: Mika Westerberg > Reviewed-by: Andy Shevchenko > Signed-off-by: qiujiang This one fine to me. > --- > drivers/gpio/gpio-dwapb.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > index 2ae506f..043e1c2 100644 > --- a/drivers/gpio/gpio-dwapb.c > +++ b/drivers/gpio/gpio-dwapb.c > @@ -28,6 +28,8 @@ > #include > #include > > +#include "gpiolib.h" > + > #define GPIO_SWPORTA_DR 0x00 > #define GPIO_SWPORTA_DDR 0x04 > #define GPIO_SWPORTB_DR 0x0c > @@ -437,6 +439,10 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, > else > port->is_registered = true; > > + /* Add GPIO-signaled ACPI event support */ > + if (pp->irq) > + acpi_gpiochip_request_interrupts(&port->gc); > + > return err; > } > > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko