Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932648AbcCJVLh (ORCPT ); Thu, 10 Mar 2016 16:11:37 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51454 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932231AbcCJVLd (ORCPT ); Thu, 10 Mar 2016 16:11:33 -0500 Date: Thu, 10 Mar 2016 16:11:30 -0500 (EST) Message-Id: <20160310.161130.1092102174723373091.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, kevin.smith@elecsyscorp.com Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: rework port state setter From: David Miller In-Reply-To: <1457393057-22618-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1457393057-22618-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Mar 2016 13:11:32 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 517 Lines: 13 From: Vivien Didelot Date: Mon, 7 Mar 2016 18:24:17 -0500 > Apply a few non-functional changes on the port state setter: > > * add a dynamic debug message with state names to track changes > * explicit states checking instead of assuming their numeric values > * lock mutex only once when changing several port states > * use bitmap macros to declare and access port_state_update_mask > > Signed-off-by: Vivien Didelot Applied.