Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932685AbcCJVLn (ORCPT ); Thu, 10 Mar 2016 16:11:43 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51472 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932642AbcCJVLh (ORCPT ); Thu, 10 Mar 2016 16:11:37 -0500 Date: Thu, 10 Mar 2016 16:11:35 -0500 (EST) Message-Id: <20160310.161135.1253557043734177722.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, kevin.smith@elecsyscorp.com Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: read then write PVID From: David Miller In-Reply-To: <1457393079-22740-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1457393079-22740-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Mar 2016 13:11:36 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 426 Lines: 12 From: Vivien Didelot Date: Mon, 7 Mar 2016 18:24:39 -0500 > The port register 0x07 contains more options than just the default VID, > even though they are not used yet. So prefer a read then write operation > over a direct write. > > This also allows to keep track of the change through dynamic debug. > > Signed-off-by: Vivien Didelot Applied.