Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996AbcCJWlw (ORCPT ); Thu, 10 Mar 2016 17:41:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754969AbcCJWlt (ORCPT ); Thu, 10 Mar 2016 17:41:49 -0500 Date: Thu, 10 Mar 2016 16:41:46 -0600 From: Josh Poimboeuf To: Jessica Yu Cc: Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Petr Mladek , Rusty Russell , Steven Rostedt , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] modules: split part of complete_formation() into prepare_coming_module() Message-ID: <20160310224146.GB12493@treble.redhat.com> References: <1457561637-24770-1-git-send-email-jeyu@redhat.com> <1457561637-24770-2-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1457561637-24770-2-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 18 On Wed, Mar 09, 2016 at 05:13:55PM -0500, Jessica Yu wrote: > Put all actions in complete_formation() that are performed after > module->state is set to MODULE_STATE_COMING into a separate function > prepare_coming_module(). This split prepares for the removal of the > livepatch module notifiers in favor of hard-coding function calls to > klp_module_{coming,going} in the module loader. > > The complete_formation -> prepare_coming_module split will also make error > handling easier since we can jump to the appropriate error label to do any > module GOING cleanup after all the COMING-actions have completed. > > Signed-off-by: Jessica Yu Reviewed-by: Josh Poimboeuf -- Josh