Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932834AbcCJXJF (ORCPT ); Thu, 10 Mar 2016 18:09:05 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32777 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932355AbcCJXJA convert rfc822-to-8bit (ORCPT ); Thu, 10 Mar 2016 18:09:00 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example From: Julien Chauveau In-Reply-To: <56DEA4D6.10008@suse.de> Date: Fri, 11 Mar 2016 00:08:56 +0100 Cc: Geert Uytterhoeven , "linux-input@vger.kernel.org" , linux-rockchip , LAKML , =?utf-8?Q?Heiko_St=C3=BCbner?= , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree , LKML Content-Transfer-Encoding: 8BIT Message-Id: References: <1457375055-5544-1-git-send-email-afaerber@suse.de> <56DEA4D6.10008@suse.de> To: =?utf-8?Q?Andreas_F=C3=A4rber?= X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2258 Lines: 57 > Le 8 mars 2016 à 11:09, Andreas Färber a écrit : > > Am 08.03.2016 um 09:54 schrieb Geert Uytterhoeven: >> On Mon, Mar 7, 2016 at 7:24 PM, Andreas Färber wrote: >>> Drop #address-cells and #size-cells, which are not required by the >>> gpio-keys binding documentation, as button sub-nodes are not devices. >>> >>> Reported-by: Julien Chauveau >>> Signed-off-by: Andreas Färber >>> --- >>> Documentation/devicetree/bindings/input/gpio-keys.txt | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt >>> index 21641236c095..1552a11f6786 100644 >>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt >>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt >>> @@ -34,8 +34,6 @@ Example nodes: >>> >>> gpio_keys { > > While at it, I was told the preferred node naming would be dashes, not > underscores. The deeper we dig, the more we find. I agree, here we should use dashes, not underscores. So "gpio-keys" instead of "gpio_keys". > >>> compatible = "gpio-keys"; >>> - #address-cells = <1>; >>> - #size-cells = <0>; >>> autorepeat; > > Also a white line here may be optically more pleasant. I agree. > >>> button@21 { >> >> FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd": >> (http://www.spinics.net/lists/devicetree/msg117206.html) applied: >> >> Warning (unit_address_vs_reg): Node /keyboard/button@21 has a unit >> name, but no reg property > > My v2 GeekBox patch did have *-cells and a reg property, but Julien > asked I drop that: https://patchwork.kernel.org/patch/8246481/ > > Are you suggesting we should add a reg property here and drop this patch > or go with this patch but follow up to not use @21? I may be wrong but I think that if the unit-address has no meaning and is not used, then it should be removed. By the way, I think the warning message is wrong. It should be _address_ instead of name: "Node has a unit address, but no reg property". Julien