Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933402AbcCKByz (ORCPT ); Thu, 10 Mar 2016 20:54:55 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:45640 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933171AbcCKByx (ORCPT ); Thu, 10 Mar 2016 20:54:53 -0500 Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt To: Sergei Shtylyov , References: <1457053798-93513-1-git-send-email-huangdaode@hisilicon.com> <1457053798-93513-4-git-send-email-huangdaode@hisilicon.com> <56D98F8F.5010700@cogentembedded.com> CC: , , , , , , , , , , From: Daode Huang Message-ID: <56E2251D.905@hisilicon.com> Date: Fri, 11 Mar 2016 09:53:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56D98F8F.5010700@cogentembedded.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.13.197] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.56E22568.00D7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f4bcc934381237b709aceeceb37ac6ef Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 67 On 2016/3/4 21:37, Sergei Shtylyov wrote: > Hello. > > On 3/4/2016 4:09 AM, Daode Huang wrote: > >> In V2 chip, when sending mamagement packets, the driver should >> config the port id to BD descs. >> >> Signed-off-by: Daode Huang >> Signed-off-by: Lisheng >> --- >> drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++ >> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 + >> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++++ >> 3 files changed, 8 insertions(+) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h >> b/drivers/net/ethernet/hisilicon/hns/hnae.h >> index 1cbcb9f..11a3f97 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h >> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h > [...] >> @@ -516,6 +518,7 @@ struct hnae_handle { >> int q_num; >> int vf_id; >> u32 eport_id; >> + u32 dport_id; /*v2 tx bd should fill the dport_id*/ > > Please add spaces after /* and before */ (like it's done in other > places in this driver). > Hi MBR, Sergei, Thanks for you comments, will change it in next version. Daode. > [...] >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> index 6250a42..b45dcc2 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c >> @@ -69,6 +69,10 @@ static void fill_v2_desc(struct hnae_ring *ring, >> void *priv, >> hnae_set_bit(rrcfv, HNSV2_TXD_VLD_B, 1); >> hnae_set_field(bn_pid, HNSV2_TXD_BUFNUM_M, 0, buf_num - 1); >> >> + /*fill port_id in the tx bd for sending management pkts*/ > > Likewise. > >> + hnae_set_field(bn_pid, HNSV2_TXD_PORTID_M, >> + HNSV2_TXD_PORTID_S, ring->q->handle->dport_id); >> + >> if (type == DESC_TYPE_SKB) { >> skb = (struct sk_buff *)priv; >> > > MBR, Sergei > > > . >