Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933421AbcCKB7q (ORCPT ); Thu, 10 Mar 2016 20:59:46 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:55047 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933259AbcCKB7o (ORCPT ); Thu, 10 Mar 2016 20:59:44 -0500 Subject: Re: [PATCH net 4/6] net: hns: adds uc match for debug port To: Sergei Shtylyov , References: <1457053798-93513-1-git-send-email-huangdaode@hisilicon.com> <1457053798-93513-5-git-send-email-huangdaode@hisilicon.com> <56D99007.6090804@cogentembedded.com> CC: , , , , , , , , , , From: Daode Huang Message-ID: <56E22651.3030903@hisilicon.com> Date: Fri, 11 Mar 2016 09:58:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56D99007.6090804@cogentembedded.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.13.197] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.56E2268B.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c1bea78455c95ccf22ff8ed7ab320878 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1743 Lines: 60 On 2016/3/4 21:39, Sergei Shtylyov wrote: > On 3/4/2016 4:09 AM, Daode Huang wrote: > >> This patch adds uc match for debug port by: >> 1)Enables uc match of debug port when initializing gmac >> 2)Enables uc match of mac address register2 >> >> Signed-off-by: Daode Huang >> Signed-off-by: lipeng > Lipeng is his full name. i will change it to another style (Peng Li ) > True/full name is required here. > >> --- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 18 >> +++++++++++++++++- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 2 ++ >> 2 files changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c >> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c >> index b8517b0..2591a51 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c > [...] >> @@ -407,8 +419,12 @@ static void hns_gmac_set_mac_addr(void *mac_drv, >> char *mac_addr) >> >> u32 low_val = mac_addr[5] | (mac_addr[4] << 8) >> | (mac_addr[3] << 16) | (mac_addr[2] << 24); >> + >> + u32 val = dsaf_read_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG); >> + u32 sta_addr_en = dsaf_get_bit(val, GMAC_ADDR_EN_B); > > Empty line needed after declarations. > agree, thanks Daode. >> dsaf_write_dev(drv, GMAC_STATION_ADDR_LOW_2_REG, low_val); >> - dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG, high_val); >> + dsaf_write_dev(drv, GMAC_STATION_ADDR_HIGH_2_REG, >> + high_val | (sta_addr_en << GMAC_ADDR_EN_B)); >> } >> } >> > [...] > > MBR, Sergei > > > . >