Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbcCKDCz (ORCPT ); Thu, 10 Mar 2016 22:02:55 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:43212 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753873AbcCKDCx (ORCPT ); Thu, 10 Mar 2016 22:02:53 -0500 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <56E23523.4020201@linux.vnet.ibm.com> Date: Fri, 11 Mar 2016 08:31:55 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org CC: hughd@google.com, aneesh.kumar@linux.vnet.ibm.com, kirill@shutemov.name, n-horiguchi@ah.jp.nec.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [RFC 1/9] mm/hugetlb: Make GENERAL_HUGETLB functions PGD implementation aware References: <1457525450-4262-1-git-send-email-khandual@linux.vnet.ibm.com> In-Reply-To: <1457525450-4262-1-git-send-email-khandual@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031103-0025-0000-0000-000003278C7E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 500 Lines: 10 On 03/09/2016 05:40 PM, Anshuman Khandual wrote: > Currently both the ARCH_WANT_GENERAL_HUGETLB functions 'huge_pte_alloc' > and 'huge_pte_offset' dont take into account huge page implementation > at the PGD level. With addition of PGD awareness into these functions, > more architectures like POWER which also implements huge pages at PGD > level (along with PMD level), can use ARCH_WANT_GENERAL_HUGETLB option. Hugh/Mel/Naoya/Andrew, Thoughts/inputs/suggestions ? Does this change looks okay ?