Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934246AbcCKDhW (ORCPT ); Thu, 10 Mar 2016 22:37:22 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:49449 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934111AbcCKDhS (ORCPT ); Thu, 10 Mar 2016 22:37:18 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: jaegeuk@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <82d6d0f59c4ef463c085d07d1cb3b1cc> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Shawn Lin To: Jaegeuk Kim Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Shawn Lin Subject: [PATCH 7/8] f2fs: remove unnecessary inline checking for f2fs_convert_inline_inode Date: Fri, 11 Mar 2016 11:29:15 +0800 Message-Id: <1457666955-14600-1-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1457666880-14311-1-git-send-email-shawn.lin@rock-chips.com> References: <1457666880-14311-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 27 If failing to check inline data flag for f2fs_convert_inline_inode, it will return 0. So we don't need to check it twice before we are going to do f2fs_convert_inline_page. Signed-off-by: Shawn Lin --- fs/f2fs/inline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 394feee..76e096a 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -173,8 +173,7 @@ int f2fs_convert_inline_inode(struct inode *inode) set_new_dnode(&dn, inode, ipage, ipage, 0); - if (f2fs_has_inline_data(inode)) - err = f2fs_convert_inline_page(&dn, page); + err = f2fs_convert_inline_page(&dn, page); f2fs_put_dnode(&dn); out: -- 2.3.7