Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753558AbcCKFcz (ORCPT ); Fri, 11 Mar 2016 00:32:55 -0500 Received: from mail-bl2on0055.outbound.protection.outlook.com ([65.55.169.55]:49314 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751204AbcCKFcy (ORCPT ); Fri, 11 Mar 2016 00:32:54 -0500 Authentication-Results: spf=none (sender IP is 192.88.168.50) smtp.mailfrom=lvd4224.freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=nxp.com; From: Rajesh Bhagat To: , CC: , , Rajesh Bhagat Subject: [PATCH] xhci: fix typo in babble endpoint handling comment Date: Fri, 11 Mar 2016 10:27:49 +0530 Message-ID: <1457672269-29584-1-git-send-email-rajesh.bhagat@nxp.com> X-Mailer: git-send-email 1.7.7.4 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131021458720765048;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC008;1:5BpF5J2BIkh0AvjXsLWNOXJhUdIqL8uGH1c/OZOYFK+t0qXdgUg87YPTWZJegQzAAIJALzdID/1NtYbhQgyQ5JyCdzmb8nJPG4yDwGUrepJzQ15xaMuDHmKextPTC9fZ6Dv0Nm2mJRxYlSGfPZ82wn9lV99bRRpSoW0JdrsrozFl9gu31YCgzEz9/Z2tc07oVFG8WPFZEF6CeVJX4IGVDPl+jHr64wPdnpmwMzcB+uLd3vK/tAhmtd/rrBFHzZymXYofas6BzAbkyLEmmQa7GTntlT2FSXT/OmfK+r/bVkNrLvMc/FmoaVsc4Ph2JYuSxfPdAtR6/6T/BhOJUGi2wDJkQaHtTmIObDQG92mE+mW+ejF7mCJshGdtGVJ5lmGwntPBjcD9gBsEhAhtrYfLJF7/0yOgrmYvnGr5niCXX7Cz4ePdQfDMkl1fHjHF8NZiZJXCze/s/7N6ajruPs0ILpHkP7puaAmGuTCQ+lF92gg= X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(6039001)(2980300002)(428002)(189002)(199003)(50986999)(45336002)(2906002)(86372001)(1096002)(1220700001)(46386002)(4326007)(229853001)(36756003)(16796002)(90966002)(101416001)(81166005)(11100500001)(5008740100001)(48376002)(47776003)(19580405001)(105586002)(189998001)(50466002)(92566002)(5003940100001)(50226001)(586003)(33646002)(19580395003)(42186005)(52956003)(6806005)(5001770100001)(103686003)(87936001)(15975445007)(106466001)(7059030)(42882005)(4720700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR03MB500;H:tx30smr01.am.freescale.net;FPR:;SPF:None;MLV:sfv;MX:1;A:0;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: f3984310-73f3-4cdb-3478-08d34969b378 X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB500;2:UtMqNf8+2VeRBHwjN97TIlgp8SCLBFybHo2uTfrH0awM3JjQkG2UD26ME05tC0U6P4aWrZnmwGcTt4Tlu241ZmXvo4UH/f36z6Lhm0SxXnjVfApiBU2fy8dI6gAGdQbXdRCyCMSCwxArL9OYBDj04CNecj450DngHJNZgTz4QmM+P13FbmuTd5DUnGk0HZTt;3:LKw/lSeAlLP752vnoBnGBAin1lFLdnHmSZTXCVeIYDybGS6EvA59LTiD3/I0BRycDR/I06O+yr1OQDKDfbQfqMxSezMfYIWe/pTA1sosHQHW3zqON5HjalLJztK+HFXQNNE1UR442jFXsMMXJ+mj3vC2CgmjFvJWpTGLvbrFmnL08oYyKi3RiCI/bOYpY4uklRxT/2JZel1+W3Hz4Dsl1pk1IBgV/vLj3sLA+0XOCzE=;25:nLFQ6z2iEOu0zKJyo1LOeqaIehh5xJfs0opniLcPhamKTlDAreGucb/4b1b1Do8vW4/YI/68iB8AJYUhS5TcmayzJO9rbJr3HjKd7NDxd7mQ0bagZsPoI2nfRIDobOcRBpUBeJPgRSqIkjswldVDqdiWlCC12hyDl5Yld2qwzzbK+3uwdp7pkH6iDkc+fSBQ//WiG0CmfmEm9aFE2aqn6iwYNRGgLUCACGHD+ln3MTm4vX4YdW0GKVYZOUdmGwlEyrLys/OCKYhEsUHJWMOm0//iMu5cfDnUClDWIB08eo/uVoZOxQzpPGTKXCLH+Gpg55UOZqSVMOI1P3Y7I5XtwA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB500; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(5005006)(13024025)(13015025)(13017025)(13023025)(10201501046)(3002001);SRVR:BL2PR03MB500;BCL:0;PCL:0;RULEID:(400006);SRVR:BL2PR03MB500; X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB500;4:2XtUoz42hHXRHQdfIXRNjNIgF05k+6kPPGmSxLS8dLJt2qJQZ6u4XHzirT2SPZC2aLsCXM0/qgre2+3jvAl3c2HLTxfcOYOvPNyN0BCwb7qqzZgWgRJaRXXSj302VhxJDkVvwwYZM+LhJjY1aMJiI+ta8P0ofreca45aTSnlemvC6ukZnQcrf9CZeIJrHco8GhaYhhjaSsC+CMUVlOU5w3jb08lWjPcdb+PXReK8le6G/UoN7r9PcMcg+EyUo1WW4DxG9EfSDCwtfxvcjLXeD0rNduYod1E1skM79Qqhm4jQxSfrD3Gg2+35Hl6mBSZO+2qeYls8iQz7V6FW/lD6cwOS3IVqYhE0AX6aUxolD60NZzHzXz5ycluqb4YwftZLxvqAkaouYdYFxLSH54m5T9PIiCHctLCfU7DDWZQVNWcw3Bc3i40oOUADWiiDggGQePAG7WzRrJKY+2MKvdyzqA== X-Forefront-PRVS: 087894CD3C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR03MB500;23:vCW45HWo+GmGbs2Z/8WNND0Mi8ynEz3t7kAn10WHhc?= =?us-ascii?Q?o2o52cXv4KQKQp3GB5LklDBKQZab6nrzdcQL1WqkvHjTlekKChjpB+Q1yAOP?= =?us-ascii?Q?XgRr05YcMkGC9N6sD/XnWzbEDMAmHp6jJVMoF3IPv0DAcKMI0zabROpLbu9z?= =?us-ascii?Q?QThU0gLlnPC1D5bNa6AtuXpOzZaQ3EEWDsDLlO3MBGqjZCch5tR9TrScJCdA?= =?us-ascii?Q?/UCQSJgCrU14GWFdmAOVmu48ONqjA1FuZquif1J0u+/Y8kBOLlvjroxnDKp2?= =?us-ascii?Q?eUDSvDxTC2PjcPtJm0bDkUvxeiC4L2m97uY9F/5xu2FTsLKML/zj+yngvus6?= =?us-ascii?Q?jCvtXeBQ9bIeC6wT5PeYqM+cnRDiYKsW6uuwRgb/nK+xAr7dB5n8Y2xCCOU9?= =?us-ascii?Q?7WhlWMjBwE01FZnHq+dBOYqK0qsb27JMolOUYV/KnZMxhZmeZkFpDeSHhMi0?= =?us-ascii?Q?ro4uVlIWgncn/fv9PHb5Kade7yDgmpp1ekYWBm9/VWS/Rm9cBRyRdpa3SpGQ?= =?us-ascii?Q?BixZQTpjlQmkjQdjDoZyZSHnfkX/zG18q4CmdiKpx46D97HkqHeCijwoixa7?= =?us-ascii?Q?R39+8Dt7EjhZMZHvUSXVTP8ynBYPfnjFm3MK0+v9x2zPkjSuK+z41EvxwELU?= =?us-ascii?Q?cgIZYBBiW9gOtLw45AhZYQ9kSFvdw5ttfigHyld3bOUucA814Z+HeAXkr+X0?= =?us-ascii?Q?cbLQoLiF66zeyWLkuzy6TJE8KKipm7HQi+BPBCxbkeWnNV2l7SBXnUk/wVW5?= =?us-ascii?Q?yOgAKZlDOMMC8ZgSt5N6V04cyiQ2TEsP+/UV09TiMESIZy+ipiLMsCVR+A+b?= =?us-ascii?Q?k6gKEt1kz3uvlS2/1q3wuqm/FPkqqttcfxyd2WYOELSe0f119FTWp1AH80UL?= =?us-ascii?Q?PYZOPpYTl/4QcC5DcpIM2WpXCsx4P+icN4tfWWqLUUleiwJ+qetf9KYIeoiN?= =?us-ascii?Q?eMcD/S+vpHHqOiNvkaTUUhTsMUJZcW5fwH0xBAyBXeOQhOoIDEyCXzXlis6v?= =?us-ascii?Q?LopyfhxWBBIbGhXIDIiJszx/uYw7a01f1UkgSBCSDPHQRvd5erLugoxrkmgk?= =?us-ascii?Q?2Y3WA+nHK7/bmpLL+Jpucfs/TICYgNXV1B01PYFgli/zpnDqPx0J2HnC3sAu?= =?us-ascii?Q?YIVU8OB62dD0HV+4PHKZCKq3RRybf127r39ygdp95TPO1Q75IK1Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR03MB500;5:ldnPOoGedg9Q5firbJRlfyGbKwX0KdMsA3bUffHVumpacrQgAiEvL4RCPiMvr7KDUnJo8ae7msvwgqmjQ7eW2r48JIiXIFADd+OJVkQdMlgqIUtJP3zoa/t1ZVGw7LwS6bUr4RGuw3IpywGDwBpTWbZh0D/M3Cj3pdv5lcD1RtY=;24:ZtYchffuqXW/Sv+4Pr1ado8MmG1ocK72nt0XJ50DWAyVMOtuS64JJHiWXFSxGRZxmc6Pn0Qi96Z5v00ln1DSQuUmsoNgxpkm4XzU7/0T26g= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2016 04:57:51.9049 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB500 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 27 The 0.95 xHCI spec says that non-control endpoints will be halted if a babble is detected on a transfer. The 0.96 xHCI spec says all types of endpoints will be halted when a babble is detected. Some hardware that claims to be 0.95 compliant halts the control endpoint anyway. Reference: http://www.spinics.net/lists/linux-usb/msg21755.html Signed-off-by: Rajesh Bhagat --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 3915657..59841a9 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci, if (trb_comp_code == COMP_TX_ERR || trb_comp_code == COMP_BABBLE || trb_comp_code == COMP_SPLIT_ERR) - /* The 0.96 spec says a babbling control endpoint + /* The 0.95 spec says a babbling control endpoint * is not halted. The 0.96 spec says it is. Some HW * claims to be 0.95 compliant, but it halts the control * endpoint anyway. Check if a babble halted the -- 2.6.2.198.g614a2ac