From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Rajesh Bhagat <rajesh.bhagat@nxp.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
        Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: Re: [PATCH] xhci: fix typo in babble endpoint handling comment
In-Reply-To: <1457672269-29584-1-git-send-email-rajesh.bhagat@nxp.com>
References: <1457672269-29584-1-git-send-email-rajesh.bhagat@nxp.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Fri, 11 Mar 2016 08:54:29 +0200
Message-ID: <87lh5pcxne.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2533
Lines: 68

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:

> [ text/plain ]
> The 0.95 xHCI spec says that non-control endpoints will be halted if a
> babble is detected on a transfer.  The 0.96 xHCI spec says all types of
> endpoints will be halted when a babble is detected.  Some hardware that
> claims to be 0.95 compliant halts the control endpoint anyway.
>
> Reference: http://www.spinics.net/lists/linux-usb/msg21755.html
>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>

Reviewed-by: Felipe Balbi <balbi@kernel.org>

> ---
>  drivers/usb/host/xhci-ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 3915657..59841a9 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1768,7 +1768,7 @@ static int xhci_requires_manual_halt_cleanup(struct=
 xhci_hcd *xhci,
>  	if (trb_comp_code =3D=3D COMP_TX_ERR ||
>  			trb_comp_code =3D=3D COMP_BABBLE ||
>  			trb_comp_code =3D=3D COMP_SPLIT_ERR)
> -		/* The 0.96 spec says a babbling control endpoint
> +		/* The 0.95 spec says a babbling control endpoint
>  		 * is not halted. The 0.96 spec says it is.  Some HW
>  		 * claims to be 0.95 compliant, but it halts the control
>  		 * endpoint anyway.  Check if a babble halted the
> --=20
> 2.6.2.198.g614a2ac
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJW4mulAAoJEIaOsuA1yqREWLEQALRCRy7WOgnr8k4eCb85BGZm
TKL1RW4fI1dRwMcqXRCXwhf5mFXWMSiguVQY9XZW+pI9oKMs6735tya8m0P2YR7w
I3TpyMU20/B8acDaeJ8/PCv1UZqMLBb3Qpx4Lu++j+t0hHxYIHvW+agsoqziNoSE
piFruS5zAG/iJMm8+WX8hUJWlWpFluCyBK82GMs8a5INKGXQedUnIZdX1wKXt2dO
r+8iXdgOb6KTWBgvQ0sm0CB3mqVs5fOq/xeofwHRq1GB1M05moz4IFey9qvuvi7u
DYYOZULcHvLFoj0oExWYARAWg0FL9becwft13WkCwNSG7khW2TW08WzSTarBGJuy
6Pr8Ms2JkVjqPV+i6upn5/U5iWVQLSkC6wtJQH2IIKOqtDpnIHath0TUFSxSfUp1
OS11VSO5ZHJlGADGhikec8GrrKE1sPEz5gL/p0pN/a9KKqGDZbVOfyr+4gZ6T0+7
T8bdIwr0kMc6+kN4tmrR2Be7mtH5x53vLg4ENus6cwO3sdlufr4zw2ChmbhVWXGY
Hq5uLmNHeVu62awQIlgNQCpGPiuULoB47+Yjg7O6sgql+/AgJTFF+/9V79w+BdSf
M94g3XOeqYbpF0yjpBovrJ1LXqFKz/a4Oy7QIosygAC1RPquZspbWc3wZs5vQZdS
baqmb/HzbgazKuhMYmt9
=2gy3
-----END PGP SIGNATURE-----
--=-=-=--