Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934625AbcCKHa6 (ORCPT ); Fri, 11 Mar 2016 02:30:58 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36169 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934568AbcCKHaq convert rfc822-to-8bit (ORCPT ); Fri, 11 Mar 2016 02:30:46 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH] android: lmk: add swap pte pmd in tasksize From: yalin wang In-Reply-To: <1457681032-178195-1-git-send-email-albert.lubing@hisilicon.com> Date: Fri, 11 Mar 2016 15:30:38 +0800 Cc: gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, suzhuangluan@hisilicon.com, yudongbin@hisilicon.com, xuyiping@hisilicon.com, chenxiang9@huawei.com, oliver.fu@hisilicon.com, liuzixing@huawei.com, shimingxing@hisilicon.com, alan.wei@hisilicon.com, saberlily.xia@hisilicon.com, puck.chen@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com Content-Transfer-Encoding: 8BIT Message-Id: <8DA5D99D-7542-4ABB-9DB4-076B255A5F75@gmail.com> References: <1457681032-178195-1-git-send-email-albert.lubing@hisilicon.com> To: Lu Bing X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 38 > On Mar 11, 2016, at 15:23, Lu Bing wrote: > > From: l00215322 > > Many android devices have zram,so we should add "MM_SWAPENTS" in tasksize. > Refer oom_kill.c,we add pte&pmd also. > > Reviewed-by: Chen Feng > Reviewed-by: Fu Jun > Reviewed-by: Xu YiPing > Reviewed-by: Yu DongBin > Signed-off-by: Lu Bing > --- > drivers/staging/android/lowmemorykiller.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > index 8b5a4a8..0817d3b 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -139,7 +139,9 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) > task_unlock(p); > continue; > } > - tasksize = get_mm_rss(p->mm); > + tasksize = get_mm_rss(p->mm) + > + get_mm_counter(p->mm, MM_SWAPENTS) + > + atomic_long_read(&p->mm->nr_ptes) + mm_nr_pmds(p->mm); why not introduce a mm_nr_ptes() help function here ? more clear to see . > task_unlock(p); > if (tasksize <= 0) > continue; > -- > 1.8.3.2 >