Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964819AbcCKIkO (ORCPT ); Fri, 11 Mar 2016 03:40:14 -0500 Received: from mail-qg0-f47.google.com ([209.85.192.47]:36295 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935351AbcCKIkI (ORCPT ); Fri, 11 Mar 2016 03:40:08 -0500 Date: Fri, 11 Mar 2016 10:40:03 +0200 From: Andrey Utkin To: Hans Verkuil Cc: Linux Media , "linux-kernel@vger.kernel.org" , "kernel-mentors@selenic.com" , devel@driverdev.osuosl.org, kernel-janitors , Mauro Carvalho Chehab , Andrey Utkin Subject: Re: [RFC PATCH v0] Add tw5864 driver Message-ID: <20160311104003.1cad89f3@zver> In-Reply-To: <56E27B12.1000803@xs4all.nl> References: <1451785302-3173-1-git-send-email-andrey.utkin@corp.bluecherry.net> <56938969.30104@xs4all.nl> <56B866D9.5070606@xs4all.nl> <20160309162924.6e6ebddf@zver> <56E27B12.1000803@xs4all.nl> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 37 On Fri, 11 Mar 2016 09:00:18 +0100 Hans Verkuil wrote: > The reason is likely to be the tw5864_queue_setup function which has > not been updated to handle CREATE_BUFS support correctly. It should > look like this: > > static int tw5864_queue_setup(struct vb2_queue *q, > unsigned int *num_buffers, > unsigned int *num_planes, unsigned int > sizes[], void *alloc_ctxs[]) > { > struct tw5864_input *dev = vb2_get_drv_priv(q); > > if (q->num_buffers + *num_buffers < 12) > *num_buffers = 12 - q->num_buffers; > > alloc_ctxs[0] = dev->alloc_ctx; > if (*num_planes) > return sizes[0] < H264_VLC_BUF_SIZE ? -EINVAL : 0; > > sizes[0] = H264_VLC_BUF_SIZE; > *num_planes = 1; > > return 0; > } Thanks for suggestion, but now the failure looks this way: Streaming ioctls: test read/write: OK fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY fail: v4l2-test-buffers.cpp(703): buf.check(q, last_seq) fail: v4l2-test-buffers.cpp(976): captureBufs(node, q, m2m_q, frame_count, false) test MMAP: FAIL Will check that later. If you have any suggestions, I would be very grateful.