Subject: Re: [PATCH v8 00/17] add fixes, device quirks, error recovery,
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
        Yaniv Gardi <ygardi@codeaurora.org>
References: <1457624241-20525-1-git-send-email-ygardi@codeaurora.org>
 <yq1k2l9lozl.fsf@sermon.lab.mkp.net>
Cc: James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org
From: Hannes Reinecke <hare@suse.de>
Message-ID: <56E28703.4090702@suse.de>
Date: Fri, 11 Mar 2016 09:51:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <yq1k2l9lozl.fsf@sermon.lab.mkp.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1105
Lines: 32

On 03/11/2016 03:36 AM, Martin K. Petersen wrote:
>>>>>> "Yaniv" == Yaniv Gardi <ygardi@codeaurora.org> writes:
> 
> Yaniv> V8: fixed cyclic dependency by removing ufs_quirk.c that was
> Yaniv> previously added in V7 06/17, and moving its code into ufshcd.c
> 
> Patch 6 is now different yet it retains Reviewed-by: tags from the
> previous version. These should have been removed.
> 
> But if Hannes is OK with the changed version you don't need to
> resend. Hannes, if you would be so kind to take a second look?
> 
As indicated, I'm still not happy with the timeout handler, it
really should be sending real command aborts and not just extending
the timeout.
But it's better then nothing, and having this patchset in leaves us
with more time to discuss other matters.
EG ioctl interfaces ;-)

So:

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)