Subject: Re: [PATCH] android: lmk: add swap pte pmd in tasksize
To: yalin wang <yalin.wang2010@gmail.com>,
        Lu Bing <albert.lubing@hisilicon.com>
References: <1457681032-178195-1-git-send-email-albert.lubing@hisilicon.com>
 <8DA5D99D-7542-4ABB-9DB4-076B255A5F75@gmail.com>
CC: <gregkh@linuxfoundation.org>, <arve@android.com>, <riandrews@android.com>,
        <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
        <kirill.shutemov@linux.intel.com>, <suzhuangluan@hisilicon.com>,
        <yudongbin@hisilicon.com>, <xuyiping@hisilicon.com>,
        <chenxiang9@huawei.com>, <oliver.fu@hisilicon.com>,
        <liuzixing@huawei.com>, <shimingxing@hisilicon.com>,
        <alan.wei@hisilicon.com>, <saberlily.xia@hisilicon.com>,
        <dan.zhao@hisilicon.com>, <linuxarm@huawei.com>
From: Chen Feng <puck.chen@hisilicon.com>
Message-ID: <56E28A69.9040409@hisilicon.com>
Date: Fri, 11 Mar 2016 17:05:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <8DA5D99D-7542-4ABB-9DB4-076B255A5F75@gmail.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1480
Lines: 48


On 2016/3/11 15:30, yalin wang wrote:
> 
>> On Mar 11, 2016, at 15:23, Lu Bing <albert.lubing@hisilicon.com> wrote:
>>
>> From: l00215322 <albert.lubing@hisilicon.com>
>>
>> Many android devices have zram,so we should add "MM_SWAPENTS" in tasksize.
>> Refer oom_kill.c,we add pte&pmd also.
>>
>> Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
>> Reviewed-by: Fu Jun <oliver.fu@hisilicon.com>
>> Reviewed-by: Xu YiPing <xuyiping@hisilicon.com>
>> Reviewed-by: Yu DongBin <yudongbin@hisilicon.com>
>> Signed-off-by: Lu Bing <albert.lubing@hisilicon.com>
>> ---
>> drivers/staging/android/lowmemorykiller.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
>> index 8b5a4a8..0817d3b 100644
>> --- a/drivers/staging/android/lowmemorykiller.c
>> +++ b/drivers/staging/android/lowmemorykiller.c
>> @@ -139,7 +139,9 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
>> 			task_unlock(p);
>> 			continue;
>> 		}
>> -		tasksize = get_mm_rss(p->mm);
>> +		tasksize = get_mm_rss(p->mm) +
>> +			get_mm_counter(p->mm, MM_SWAPENTS) +
>> +			atomic_long_read(&p->mm->nr_ptes) + mm_nr_pmds(p->mm);
> why not introduce a mm_nr_ptes()  help function here ?
> more clear to see .
> 
Since the code is in staging, we can add another patch to do this.


>> 		task_unlock(p);
>> 		if (tasksize <= 0)
>> 			continue;
>> -- 
>> 1.8.3.2
>>
> 
> 
> .
>