Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbcCKJ7S (ORCPT ); Fri, 11 Mar 2016 04:59:18 -0500 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:34199 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcCKJ7K (ORCPT ); Fri, 11 Mar 2016 04:59:10 -0500 Subject: Re: [RFC PATCH v0] Add tw5864 driver To: Andrey Utkin References: <1451785302-3173-1-git-send-email-andrey.utkin@corp.bluecherry.net> <56938969.30104@xs4all.nl> <56B866D9.5070606@xs4all.nl> <20160309162924.6e6ebddf@zver> <56E27B12.1000803@xs4all.nl> <20160311104003.1cad89f3@zver> Cc: Linux Media , "linux-kernel@vger.kernel.org" , "kernel-mentors@selenic.com" , devel@driverdev.osuosl.org, kernel-janitors , Mauro Carvalho Chehab , Andrey Utkin From: Hans Verkuil Message-ID: <56E296E6.8000709@xs4all.nl> Date: Fri, 11 Mar 2016 10:59:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160311104003.1cad89f3@zver> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 57 On 03/11/2016 09:40 AM, Andrey Utkin wrote: > On Fri, 11 Mar 2016 09:00:18 +0100 > Hans Verkuil wrote: >> The reason is likely to be the tw5864_queue_setup function which has >> not been updated to handle CREATE_BUFS support correctly. It should >> look like this: >> >> static int tw5864_queue_setup(struct vb2_queue *q, >> unsigned int *num_buffers, >> unsigned int *num_planes, unsigned int >> sizes[], void *alloc_ctxs[]) >> { >> struct tw5864_input *dev = vb2_get_drv_priv(q); >> >> if (q->num_buffers + *num_buffers < 12) >> *num_buffers = 12 - q->num_buffers; >> >> alloc_ctxs[0] = dev->alloc_ctx; >> if (*num_planes) >> return sizes[0] < H264_VLC_BUF_SIZE ? -EINVAL : 0; >> >> sizes[0] = H264_VLC_BUF_SIZE; >> *num_planes = 1; >> >> return 0; >> } > > Thanks for suggestion, but now the failure looks this way: > > Streaming ioctls: > test read/write: OK > fail: v4l2-test-buffers.cpp(297): g_field() == V4L2_FIELD_ANY While userspace may specify FIELD_ANY when setting a format, the driver should always map that to a specific field setting and should never return FIELD_ANY back to userspace. In this case, the 'field' field of the v4l2_buffer struct has FIELD_ANY which means it is not set correctly (or at all) in the driver. It's a common mistake, which is why v4l2-compliance tests for it :-) Regards, Hans > fail: v4l2-test-buffers.cpp(703): buf.check(q, last_seq) > fail: v4l2-test-buffers.cpp(976): captureBufs(node, q, m2m_q, frame_count, false) > test MMAP: FAIL > > Will check that later. If you have any suggestions, I would be very > grateful. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >