Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751720AbcCKKmt (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Mar 2016 05:42:49 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36178 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751434AbcCKKmm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Mar 2016 05:42:42 -0500
Date: Fri, 11 Mar 2016 11:42:40 +0100
From: Jiri Pirko <jiri@resnulli.us>
To: Lijun Ou <oulijun@huawei.com>
Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com,
        davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com,
        ogerlitz@mellanox.com, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com,
        haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com,
        lisheng011@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support
Message-ID: <20160311104239.GD3931@nanopsycho.orion>
References: <1457692631-9290-1-git-send-email-oulijun@huawei.com>
 <1457692631-9290-2-git-send-email-oulijun@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457692631-9290-2-git-send-email-oulijun@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2289
Lines: 91

Fri, Mar 11, 2016 at 11:37:09AM CET, oulijun@huawei.com wrote:
>The driver for Hisilicon RoCE is a platform driver.
>The driver will support mulitple versions of hardware. Currently only "v1"
>for hip06 SOC is supported.
>The driver includes two parts: common driver and hardware-specific
>operations. hns_roce_v1_hw.c and hns_roce_v1_hw.h are files for
>hardware-specific operations only for v1 engine, and other files(.c and .h)
>for common algorithm and common hardware operations
>
>Signed-off-by: Lijun Ou <oulijun@huawei.com>
>Signed-off-by: Wei Hu(Xavier) <xavier.huwei@huawei.com>
>Signed-off-by: Znlong <zhaonenglong@huawei.com>

<snip>

I'm sorry to be nitpicking, but you still have style issues in your
code. I believe that for newly submitted code, this should be avoided. I
already pointed that out as a comment to your last version, but you
ignored it. So again, couple of examples:

>+struct ib_ah *hns_roce_create_ah(struct ib_pd *ibpd,
>+					struct ib_ah_attr *ah_attr)

<snip>	
	
>+	ret = ib_get_cached_gid(ibpd->device, ah_attr->port_num,
>+			ah_attr->grh.sgid_index, &sgid, &gid_attr);

<snip>

>+int hns_roce_bitmap_alloc_range(
>+					struct hns_roce_bitmap *bitmap,
>+					int cnt, int align, u32 *obj)

<snip>

>+			pages =
>+				kmalloc(sizeof(*pages) * buf->nbufs,
>+					GFP_KERNEL);

<snip>

>+		dev_err(dev,
>+			"CQ alloc.Failed to find cq buf addr.\n");

<snip>

>+	resp.qp_tab_size      = hr_dev->caps.num_qps;

<snip>

>+		buddy->bits[i] =
>+			kmalloc(s * sizeof(long), GFP_KERNEL);


and many, many others similar to this. Please fix this.


Also, I don't understand why you have "_" prefix for labels:

>+
>+_error_failed_register_device:
>+	hns_roce_engine_uninit(hr_dev);
>+
>+_error_failed_engine_init:
>+	hns_roce_cleanup_bitmap(hr_dev);
>+
>+_error_failed_setup_hca:
>+	hns_roce_cleanup_icm(hr_dev);
>+
>+_error_failed_init_icm:
>+	if (hr_dev->cmd_mod)
>+		hns_roce_cmd_use_polling(hr_dev);
>+
>+_error_failed_use_event:
>+	hns_roce_cleanup_eq_table(hr_dev);
>+
>+_error_failed_eq_tabel:
>+	hns_roce_cmd_cleanup(hr_dev);
>+
>+_error_failed_cmd_init:
>+	(void)hns_roce_engine_reset(hr_dev, 0);
>+
>+_error_failed_reset_engine:
>+	hns_roce_free_cfg(hr_dev);
>+
>+_error_failed_get_cfg:
>+	ib_dealloc_device(&hr_dev->ib_dev);
>+
>+	return ret;
>+}