Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbcCKNXs (ORCPT ); Fri, 11 Mar 2016 08:23:48 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:36566 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbcCKNXj (ORCPT ); Fri, 11 Mar 2016 08:23:39 -0500 Date: Fri, 11 Mar 2016 15:23:34 +0200 From: Andrey Utkin To: Hans Verkuil Cc: Linux Media , "linux-kernel@vger.kernel.org" , "kernel-mentors@selenic.com" , devel@driverdev.osuosl.org, kernel-janitors , Mauro Carvalho Chehab , Andrey Utkin Subject: Re: [RFC PATCH v0] Add tw5864 driver Message-ID: <20160311152334.1c053054@zver> In-Reply-To: <56E296E6.8000709@xs4all.nl> References: <1451785302-3173-1-git-send-email-andrey.utkin@corp.bluecherry.net> <56938969.30104@xs4all.nl> <56B866D9.5070606@xs4all.nl> <20160309162924.6e6ebddf@zver> <56E27B12.1000803@xs4all.nl> <20160311104003.1cad89f3@zver> <56E296E6.8000709@xs4all.nl> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 23 On Fri, 11 Mar 2016 10:59:02 +0100 Hans Verkuil wrote: > While userspace may specify FIELD_ANY when setting a format, the > driver should always map that to a specific field setting and should > never return FIELD_ANY back to userspace. > > In this case, the 'field' field of the v4l2_buffer struct has > FIELD_ANY which means it is not set correctly (or at all) in the > driver. > > It's a common mistake, which is why v4l2-compliance tests for it :-) Thanks for great guidance Hans, finally I have solved all issues. You can review latest state at tw5864 branch, also you can review changelog of v4l2-compliance fixing at tags tw5864_pre_1.11, tw5864_pre_1.10 of https://github.com/bluecherrydvr/linux . I will make a final internal review before submission, and try to submit the driver for inclusion. Everybody is appreciated to make any comments even before submission, the actual code to review is at tw5864 branch.