Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300AbcCKOjU (ORCPT ); Fri, 11 Mar 2016 09:39:20 -0500 Received: from mail-io0-f177.google.com ([209.85.223.177]:34530 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983AbcCKOjK (ORCPT ); Fri, 11 Mar 2016 09:39:10 -0500 MIME-Version: 1.0 X-Originating-IP: [201.217.58.92] In-Reply-To: <56E2C36C.6030709@samsung.com> References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> <56DD48C1.8010004@samsung.com> <56DD9086.7070903@osg.samsung.com> <56E2C36C.6030709@samsung.com> Date: Fri, 11 Mar 2016 11:39:08 -0300 Message-ID: Subject: Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic From: Javier Martinez Canillas To: Sylwester Nawrocki Cc: Javier Martinez Canillas , Krzysztof Kozlowski , Linux Kernel , Kukjin Kim , Mauro Carvalho Chehab , "linux-samsung-soc@vger.kernel.org" , Kyungmin Park , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 26 Hello Sylwester, On Fri, Mar 11, 2016 at 10:09 AM, Sylwester Nawrocki wrote: > On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: >> Thanks, I just noticed another similar issue in the driver now and is >> that fimc_is_parse_sensor_config() uses the same struct device_node * >> for looking up the I2C sensor, port and endpoint and thus not doing a >> of_node_put() for all the nodes on the error path. >> >> I think the right fix is to have a separate struct device_node * for >> each so their reference counter can be incremented and decremented. > > Yes, the node reference count is indeed not handled very well there, > feel free to submit a patch to fix that bug. > Ok, I'll post a patch to fix that once all the in-flight patches land to avoid merge conflicts. > -- > Regards, > Sylwester Best regards, Javier