Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbcCKOtK (ORCPT ); Fri, 11 Mar 2016 09:49:10 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33831 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbcCKOtE (ORCPT ); Fri, 11 Mar 2016 09:49:04 -0500 Subject: Re: [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers To: Sergei Shtylyov References: <1457693731-6966-1-git-send-email-wxt@rock-chips.com> <56E2CC39.6050907@cogentembedded.com> Cc: Caesar Wang , Heiko Stuebner , "David S. Miller" , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Russell King , Pawel Moll , zhengxing , Alexander Kochetkov , netdev@vger.kernel.org, Michael Turquette , Kumar Gala , Stephen Boyd , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, keescook@google.com, Jiri Kosina , linux-clk@vger.kernel.org, leozwang@google.com From: Caesar Wang Message-ID: <56E2DAC4.4020105@gmail.com> Date: Fri, 11 Mar 2016 22:48:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E2CC39.6050907@cogentembedded.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2333 Lines: 82 Hi Sergei, 在 2016年03月11日 21:46, Sergei Shtylyov 写道: > Hello. > > On 3/11/2016 1:55 PM, Caesar Wang wrote: > >> This series patches are based on kernel 4.5-rc7+ version. >> Linux version 4.5.0-rc7-next-20160310+ (wxt@nb) (...) #23 SMP Fri Mar >> 11 15:55:53 > > [...] > >> 1) This series has 6 patches: (1--->6) >> net: arc_emac: make the rockchip emac document more compatible >> net: arc_emac: add phy-reset-* are optional for device tree > > I'm not seeing these patches on netdev... Sent by the patman tool. LKML: https://patchwork.kernel.org/patch/8564501/ https://patchwork.kernel.org/patch/8564511/ > >> net: arc_emac: support the phy reset for emac driver >> net: arc: trivial: cleanup the emac driver >> clk: rockchip: rk3036: fix and add node id for emac clock >> ARM: dts: rockchip: add support emac for RK3036 >> >> 2) This series patches have the following decriptions: > > Descriptions. > >> Hi Rob, David: >> PATCH[1/6-2/6]: ====> >> net: arc_emac: make the rockchip emac document more compatible >> net: arc_emac: add phy-reset-* are optional for device tree >> >> The patches change the rockchip emac document for more compatible and >> Add the phy-reset-* property for document. >> >> This patch adds the following property for arc_emac. >> >> phy-reset-* include the following: >> 1) phy-reset-gpios: >> The phy-reset-gpios is an optional property for arc emac device tree >> boot. >> Change the binding document to match the driver code. >> >> 2) phy-reset-duration: >> Different boards may require different phy reset duration. Add property >> phy-reset-duration for device tree probe, so that the boards that need >> a longer reset duration can specify it in their device tree. >> >> 3) phy-reset-active-high: >> We need that for a custom hardware that needs the reverse reset >> sequence. > > Why not infer this from the "phy-reset-gpios" prop? See: https://patchwork.kernel.org/patch/8564511/ phy-reset-active-high : If present then the reset sequence using the GPIO specified in the "phy-reset-gpios" property is reversed (H=reset state, L=operation state). Thanks, Caesar > > MBR, Sergei > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip