Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932430AbcCKOuF (ORCPT ); Fri, 11 Mar 2016 09:50:05 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33588 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbcCKOt5 convert rfc822-to-8bit (ORCPT ); Fri, 11 Mar 2016 09:49:57 -0500 MIME-Version: 1.0 In-Reply-To: <56E2AF71.2050800@gmail.com> References: <00e9fa7d4adeac2d37a42cf613837e74850d929a.1456504662.git.glider@google.com> <56D471F5.3010202@gmail.com> <56D58398.2010708@gmail.com> <56E2AF71.2050800@gmail.com> Date: Fri, 11 Mar 2016 15:49:55 +0100 Message-ID: Subject: Re: [PATCH v4 5/7] mm, kasan: Stackdepot implementation. Enable stackdepot for SLAB From: Alexander Potapenko To: Andrey Ryabinin Cc: Steven Rostedt , Dmitry Vyukov , Andrey Konovalov , Christoph Lameter , Andrew Morton , Joonsoo Kim , JoonSoo Kim , Kostya Serebryany , kasan-dev , LKML , "linux-mm@kvack.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3214 Lines: 77 On Fri, Mar 11, 2016 at 12:43 PM, Andrey Ryabinin wrote: > > > On 03/11/2016 02:18 PM, Alexander Potapenko wrote: >> On Thu, Mar 10, 2016 at 5:58 PM, Andrey Ryabinin wrote: >>> 2016-03-08 14:42 GMT+03:00 Alexander Potapenko : >>>> On Tue, Mar 1, 2016 at 12:57 PM, Andrey Ryabinin wrote: >>>>>>> >>>>>>>> + page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER); >>>>>>> >>>>>>> STACK_ALLOC_ORDER = 4 - that's a lot. Do you really need that much? >>>>>> >>>>>> Part of the issue the atomic context above. When we can't allocate >>>>>> memory we still want to save the stack trace. When we have less than >>>>>> STACK_ALLOC_ORDER memory, we try to preallocate another >>>>>> STACK_ALLOC_ORDER in advance. So in the worst case, we have >>>>>> STACK_ALLOC_ORDER memory and that should be enough to handle all >>>>>> kmalloc/kfree in the atomic context. 1 page does not look enough. I >>>>>> think Alex did some measuring of the failure race (when we are out of >>>>>> memory and can't allocate more). >>>>>> >>>>> >>>>> A lot of 4-order pages will lead to high fragmentation. You don't need physically contiguous memory here, >>>>> so try to use vmalloc(). It is slower, but fragmentation won't be problem. >>>> I've tried using vmalloc(), but turned out it's calling KASAN hooks >>>> again. Dealing with reentrancy in this case sounds like an overkill. >>> >>> We'll have to deal with recursion eventually. Using stackdepot for >>> page owner will cause recursion. >>> >>>> Given that we only require 9 Mb most of the time, is allocating >>>> physical pages still a problem? >>>> >>> >>> This is not about size, this about fragmentation. vmalloc allows to >>> utilize available low-order pages, >>> hence reduce the fragmentation. >> I've attempted to add __vmalloc(STACK_ALLOC_SIZE, alloc_flags, >> PAGE_KERNEL) (also tried vmalloc(STACK_ALLOC_SIZE)) instead of >> page_alloc() and am now getting a crash in >> kmem_cache_alloc_node_trace() in mm/slab.c, because it doesn't allow >> the kmem_cache pointer to be NULL (it's dereferenced when calling >> trace_kmalloc_node()). >> >> Steven, do you know if this because of my code violating some contract >> (e.g. I'm calling vmalloc() too early, when kmalloc_caches[] haven't >> been initialized), > > Probably. kmem_cache_init() goes before vmalloc_init(). The solution I'm currently testing is to introduce a per-CPU recursion flag that depot_save_stack() checks and bails out if it's set. In addition I look at |kmalloc_caches[KMALLOC_SHIFT_HIGH]| and in_interrupt() to see if vmalloc() is available. In the case it is not, I fall back to alloc_pages(). Right now (after 20 minutes of running Trinity) vmalloc() has been called 490 times, alloc_pages() - only 13 times. I hope it's now much better from the fragmentation point of view. > >> or is this a bug in kmem_cache_alloc_node_trace() >> itself? >> -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg