Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbcCKQBg (ORCPT ); Fri, 11 Mar 2016 11:01:36 -0500 Received: from mail-oi0-f44.google.com ([209.85.218.44]:35419 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932537AbcCKQBd (ORCPT ); Fri, 11 Mar 2016 11:01:33 -0500 MIME-Version: 1.0 In-Reply-To: <1457089198-27171-1-git-send-email-mbrugger@suse.com> References: <1457089198-27171-1-git-send-email-mbrugger@suse.com> Date: Fri, 11 Mar 2016 23:01:32 +0700 Message-ID: Subject: Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller From: Linus Walleij To: Matthias Brugger Cc: Alexandre Courbot , Quan Nguyen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 21 On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger wrote: > The standby GPIO controller can be used as a interrupt controller. > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get > a compilation error: > > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe': > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain' > priv->gc.irqdomain = priv->irq_domain; > ^ > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1 > > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller" > Signed-off-by: Matthias Brugger Quan's patch exporting the symbols has been merged by tglx so dropping this. Yours, Linus Walleij