Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932749AbcCKQqL (ORCPT <rfc822;w@1wt.eu>);
	Fri, 11 Mar 2016 11:46:11 -0500
Received: from galahad.ideasonboard.com ([185.26.127.97]:56260 "EHLO
	galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932264AbcCKQqI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 11 Mar 2016 11:46:08 -0500
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Nishanth Menon <nm@ti.com>
Cc: Russell King <linux@arm.linux.org.uk>, Tony Lindgren <tony@atomide.com>,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH] ARM: OMAP2: Fix up interconnect barrier initialization for DRA7
Date: Fri, 11 Mar 2016 18:46:07 +0200
Message-ID: <4167118.MBvk7Vsb05@avalon>
User-Agent: KMail/4.14.8 (Linux/4.1.15-gentoo-r1; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1457712748-1408-1-git-send-email-nm@ti.com>
References: <1457712748-1408-1-git-send-email-nm@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1596
Lines: 49

Hi Nishanth,

Thank you for the patch.

On Friday 11 March 2016 10:12:28 Nishanth Menon wrote:
> The following commits:
> commit 3fa609755c11 ("ARM: omap2: restore OMAP4 barrier behaviour")
> commit f746929ffdc8 ("Revert "ARM: OMAP4: remove dead kconfig option
> OMAP4_ERRATA_I688"") and
> commit ea827ad5ffbb ("ARM: DRA7: Provide proper IO map table")
> came in around the same time, unfortunately this seem to have missed
> initializing the barrier for DRA7 platforms - omap5_map_io was reused
> for dra7 till it was split out by the last patch. barrier_init
> needs to be hence carried forward as it is valid for DRA7 family of
> processors as they are for OMAP5.
> 
> Fixes: ea827ad5ffbb7 ("ARM: DRA7: Provide proper IO map table")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Original thread of report:
> http://www.spinics.net/lists/dri-devel/msg101246.html
> 
>  arch/arm/mach-omap2/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 3c87e40650cf..9821be6dfd5e 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -368,6 +368,7 @@ void __init omap5_map_io(void)
>  void __init dra7xx_map_io(void)
>  {
>  	iotable_init(dra7xx_io_desc, ARRAY_SIZE(dra7xx_io_desc));
> +	omap_barriers_init();
>  }
>  #endif
>  /*

-- 
Regards,

Laurent Pinchart