Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbcCKTWI (ORCPT ); Fri, 11 Mar 2016 14:22:08 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:35758 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbcCKTWE (ORCPT ); Fri, 11 Mar 2016 14:22:04 -0500 Subject: Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver To: Caesar Wang , Heiko Stuebner , "David S. Miller" , Rob Herring References: <1457693731-6966-1-git-send-email-wxt@rock-chips.com> <1457693731-6966-4-git-send-email-wxt@rock-chips.com> Cc: linux-rockchip@lists.infradead.org, keescook@google.com, leozwang@google.com, Alexander Kochetkov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56E31AD8.3060201@cogentembedded.com> Date: Fri, 11 Mar 2016 22:22:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1457693731-6966-4-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 33 On 03/11/2016 01:55 PM, Caesar Wang wrote: > This patch adds to support the emac phy reset. > > 1) phy-reset-gpios: > The phy-reset-gpios is an optional property for arc emac device tree boot. > Change the binding document to match the driver code. > > 2) phy-reset-duration: > Different boards may require different phy reset duration. Add property > phy-reset-duration for device tree probe, so that the boards that need > a longer reset duration can specify it in their device tree. > > 3) phy-reset-active-high: > We need that for a custom hardware that needs the reverse reset sequence. What concerns me the most about the existing (and suggested) PHY reset related props is that they are located in the MAC device node while not having *anything* to do with the MAC at all! These props actually belong to the PHY nodes, and I'm currently looking into how to handle them there, where they belong... > Of course, this patch will fix the issue on > https://patchwork.kernel.org/patch/8186801/. > > In some cases, the emac couldn't work if you don't have reset the phy. > Let's add it to happy work. > > Signed-off-by: Caesar Wang [...] MBR, Sergei