Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbcCKVeG (ORCPT ); Fri, 11 Mar 2016 16:34:06 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57744 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbcCKVeE (ORCPT ); Fri, 11 Mar 2016 16:34:04 -0500 Date: Fri, 11 Mar 2016 13:34:03 -0800 From: Greg KH To: Daeseok Youn Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH 1/2 V2] staging: dgnc: use pointer type of tty_struct Message-ID: <20160311213403.GA20084@kroah.com> References: <20160307075247.GA21011@SEL-JYOUN-D1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160307075247.GA21011@SEL-JYOUN-D1> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 14 On Mon, Mar 07, 2016 at 04:52:47PM +0900, Daeseok Youn wrote: > For using tty_alloc_driver, SerialDriver has to be pointer type. > It also has checkpatch.pl warning about Camelcase, so > SerialDriver is changed to serial_driver. Please only fix one thing per patch. This should be two different patches, right? Also it doesn't apply properly to my tree, please rebase it against the staging-testing branch of staging.git and resend. thanks, greg k-h