Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932710AbcCKWAN (ORCPT ); Fri, 11 Mar 2016 17:00:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58464 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcCKWAK (ORCPT ); Fri, 11 Mar 2016 17:00:10 -0500 Date: Fri, 11 Mar 2016 14:00:09 -0800 From: Greg Kroah-Hartman To: Gustavo Padovan Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change Message-ID: <20160311220009.GC11274@kroah.com> References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457044963-5785-1-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 29 On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Burn the old opcode to avoid any potential old userspace running the old > API to get weird errors. Changing the opcodes will make them fail right > away. > > This is just a precaution, there no upstream users of these interfaces > yet and the only user is Android, but we don't expect anyone trying to > run android userspace and all it dependencies on top of upstream kernels. > > Moreover Android should be converted to use upstream sync_files. > > Suggested-by: Rob Clark > Signed-off-by: Gustavo Padovan > --- > drivers/staging/android/uapi/sync.h | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Where does this belong in this patch series? Before it? After it? In the middle? Please resend the whole series, gather up all of the reviewed and signed-off-by markings from everyone involved, and I'll be glad to apply them. thanks, greg k-h