Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbcCLAIy (ORCPT ); Fri, 11 Mar 2016 19:08:54 -0500 Received: from mail-by2on0063.outbound.protection.outlook.com ([207.46.100.63]:2120 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751720AbcCLAIv (ORCPT ); Fri, 11 Mar 2016 19:08:51 -0500 Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <56E35E0C.9040500@caviumnetworks.com> Date: Fri, 11 Mar 2016 16:08:44 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Daney CC: "David S. Miller" , , , Florian Fainelli , Robert Richter , Sunil Goutham , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , , Radha Mohan Chintakuntla , David Daney Subject: Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code. References: <1457718791-6505-1-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1457718791-6505-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN1PR0701CA0070.namprd07.prod.outlook.com (25.163.126.38) To CY1PR07MB2136.namprd07.prod.outlook.com (25.164.112.14) X-MS-Office365-Filtering-Correlation-Id: d9e6fc57-6588-441d-ac73-08d34a0a7cc9 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;2:wFeNZmWJhvri7K1hxYFgWdu5dFjKJSyTUMyF6QYeHuEA120UxbveJJNbrPRlewSf5JCEsDM1BahoVALhwkPkPaBO0m+PxbA8mziPY71lOEHlNKKreZHlxmr6e5eiDKdXqUqGPRsY4v8Q6piHLgi5MlZiShxx9ttmL3xIWu8aNboOSatEgJnMYLJ2gd5NdDPj;3:ISrIOjWOTYFqAYchrQ38yL00OqbxxVWLXJGsYeO2+KlqozwksKBVvfMR8WF7kbnes660+BH1ny1gIy/OW37nbXnrEOLEUoNcsNah5pSVqXebfgsx/+Fonj+pzNA11mRg;25:mupHKNabT7lE8qyl0mDJoL/vBYUfHZd4mPjf0RvvdD+CpF+eKTGnFns3rVexYth5FJqCA/zm31CNwLB3bYqnMhM0TljAc6lw1K+sUBjttPzZGwFjcgihN20VxqDXzLCfSeVqR+2FVgu5T/9pxSka8nWu6sL2uR4wUIM/xepMkceLDPjEAF9c2KnvA/Og4TnWUxDRVXPAQK5T/UnM5jwHJLqDKVtr7unqmXf4CSokDJzm/iJfeNMcSiYtZBipKLTAt7js8IswG+8mUlhCYe7EHVYEiwler8CKToiA5a6dpaRJUpGa6CgwX4j+F6xQ+XHOpw5klaoGjlNAdD1yH4mQUA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;20:pXqvoddMsBzGMbYNkjD7P6fpivJWgcRoZP3urnWdhWoMWP5nE3TD4e4XseHA+v6p9WjYWOMkb6utwx36h/7YkQAi+nBOt/0DcjPtEj96R6St9/0c0FOqLmlcsbh8LcOvn6DlqpKijkXvXCWw1SfKZ89/QTap3gtzmkSy0oUz//UZXppVXV9RwPSqCk1x4S5F92mkPEFx69ukSZEM8opVf+W6erYv47gYT5C0NN8wiXXy8GVuvrl+yawS3acZriw9AGA0hlt7VPjcoimvACNtz0p647LfzhIJHoYy24It0FI6TGhcjiWZVhwq1bbw579DVI/AYJWKm5bcZUjzi1UzsrxN5jBJ3hsYxOG5ll9hLWPa4VJ+SCQco6u6l0TAfPMEbD00EQaPbyr3vvSw0eOujVFxPPRo3easb6p3RxjFDssRsynq+XUi8gmiDB8Z/LmCC+5OY9ErcMW/18TOMsVSWCeFjjktXTy3EXE/kI13r46AJa33N4s9r7Bqh9knVVVEDsuAJq+EC1SYUtsgOADpv6n4CaAeK5pdsLjHiBEpOMYaN023alvo8JANBZ3XkOYXbgHOIsOzu1sTkcHdbG4vuDk5y5ppTI4W1Cav74H/i7c= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR07MB2136;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2136; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;4:h00XCD3aI6K6zLHtI5+K7OixlKbJ7YxK0rw14eWiNXdDAOyP1+RV+Buf6rMXszADmQG7MG+nyM1GAXjR5oiwcLP0wg4c6/rcMkKNhiKUeJGwSTnF4BR4LSzCatIWgmxS16Hno/jJokfz55Y7HihXPJy6Ks43bfrAvhOU9WIHm/8l6ldLVpaY4qaJyDIB+7O0PT9DKlUyuEDxrjLvByWntxc9lkcj9aycCMy2PfkJdydqm6z6F4MQKLswYlX+XIunHgQq+6PQACk93amHovpTkq5pvWgwRPxV3IvDI1K8EilxGed2MqbdsD+gG7SzN5C/a6me6xnrPv6tUSO3/RJAeo1VE2/pAbPgULf1WyKtmjJcjjLyYr/hCvaNZpT3ptRN X-Forefront-PRVS: 0879599414 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(479174004)(24454002)(377454003)(65956001)(1096002)(66066001)(65806001)(50466002)(3846002)(189998001)(77096005)(586003)(36756003)(54356999)(50986999)(6116002)(76176999)(65816999)(230700001)(87266999)(81166005)(64126003)(33656002)(2906002)(4001350100001)(19580395003)(5008740100001)(23756003)(19580405001)(110136002)(53416004)(59896002)(42186005)(47776003)(5004730100002)(2950100001)(4326007)(92566002)(5890100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2136;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR07MB2136;23:nuco7eac/Ng6B0ooQwJPCtOfOm2O+S7K8T+xJMb?= =?iso-8859-1?Q?n/YQkN4ovx4kiaeSGz1UW3swlU+n3SySJNqoC8o+xz+gaYCcER1JXfHdMQ?= =?iso-8859-1?Q?IoqQT7CujsLxYX6khhJMjaJXiC4AuGJ6AHzlibROksuhQOcNJDjvRcO/H9?= =?iso-8859-1?Q?hHr6cjcQuhfywIVyDt9LJrQ5e+HwX8TLSQ62Y9SdkXuQP30xYILLYDdB+Z?= =?iso-8859-1?Q?liBEFDtH0LP5HCQ72C2i4bCAQFwtLNpMJSHrrrK58/TC1Ah5bOwF2cPI+/?= =?iso-8859-1?Q?Cskl5oYFD7Ldd18dgb8DGIZk0RLfgsyp4m2XGMYK98Vjc/DLZb8T+4WDfS?= =?iso-8859-1?Q?5gDfAY2XhrITudDMevnnurydfqmcADJcPYCUKvwi5YSNNp2HyC8dKjoqZC?= =?iso-8859-1?Q?akN2Jm7OslEOALLg0H4gbpzYxlTuJI+ZD7Z/jvhvGGPsD5+rJL0VcLrM8U?= =?iso-8859-1?Q?xLTKaQtgNqdFxZrc7lc2sf1zhTxtDejtFtz4kZN0y0btjfvzCLZfxsO79V?= =?iso-8859-1?Q?K8NXw5JW8C4dtwTWZhzCxFkAu50UiwwpYf7VWbn7K23l+IZrL/H/pNXl7k?= =?iso-8859-1?Q?4seQbRc/Bv5i6HuTg83RkTIGvf8c/Gr4KPlN1v2KIpcLOqFKgFU2VaQEnJ?= =?iso-8859-1?Q?Bwyms9WVl6didfdtzUpgnrGNqcNeo/qX8+/FFghjt3ClLIlBd5C/GwJJyD?= =?iso-8859-1?Q?ANdEmJOIprthuJpX+4Jd2MQiELZpNXtVblb/aoaqXYP9NRgoqDaThCg2as?= =?iso-8859-1?Q?5aDhDeWYj+4mSa63sXnyLGWMXUS0Ra4aTMJJD8e+dz6v9/+S/EcjhTO+aW?= =?iso-8859-1?Q?sUB/LEB5mswa8bPS2oAa88JUMizlL1iWnriIbv60qKAf9mkhmZEx7l0DbM?= =?iso-8859-1?Q?TxCcz0hh27g8S7evNvfSBlY44DNh7aTAj+vAH3W9Yi23zDr1bbJy/DgGMi?= =?iso-8859-1?Q?S6Z0sUjryUxhvwM5V2e6CqqUsa0gxWlB35L1VUc9TrTkNiTjrbinoEpfgw?= =?iso-8859-1?Q?lQaV3EDUx6p5iDF+8M/22vEtH32Xl6ZBwzikaI/JGBJg1FSXAuPVuf1bpF?= =?iso-8859-1?Q?Tqt9ZiDEX4cocJwMph+KluBW4dc8G1rFiOlxkypmDeRcVxpebgEi3k+A/z?= =?iso-8859-1?Q?RP2XgtaA4ZesSgJBH+tcii9Cuhw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2136;5:yUujs57gYkpnzi9XgTuicpT+9o42dfvPpqcvfp+7KEIu/hXXDk86414+mYdqk8NQZkofJqRSdqzOR/o2jIgJjbVmG5BbqPxkVmEbKORM8bIhzBowErwh2ZGoaVGD2oj/9jyjdIPWE7S/O8lRfGiZbA==;24:HNObNIKSBlTh27/LrxY0zh2ecQRWjLV4ss7PIziGxMaRtpFgRMH9JwHoREu409O/LLjtI3SqVv/t6e+KlmaPA3uBWeD00aqCW08Ktu6+3as= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2016 00:08:48.0591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2025 Lines: 49 I am going to send a new version of this set. David Daney On 03/11/2016 09:53 AM, David Daney wrote: > From: David Daney > > Changes from v1: > > - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It > is probably not necessary, but better safe than sorry... > > The firmware on many Cavium Thunder systems configures the MDIO bus > hardware to be probed as a PCI device. In order to use the MDIO bus > drivers in this configuration, we must add PCI probing to the driver. > > There are two parts to this set of three patches: > > 1) Cleanup the PHY probing code in thunder_bgx.c to handle the case > where there is no PHY attached to a port, as well as being more > robust in the face of driver loading order by use of > -EPROBE_DEFER. > > 2) Split mdio-octeon.c into two drivers, one with platform probing, > and the other with PCI probing. Common code is shared between the > two. > > Tested on several different Thunder and OCTEON systems, also compile > tested on x86_64. > > David Daney (3): > net: thunderx: Cleanup PHY probing code. > phy: mdio-octeon: Refactor into two files/modules > phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses. > > .../devicetree/bindings/net/cavium-mdio.txt | 61 ++++- > drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 29 ++- > drivers/net/phy/Kconfig | 22 +- > drivers/net/phy/Makefile | 2 + > drivers/net/phy/mdio-cavium.c | 149 +++++++++++ > drivers/net/phy/mdio-cavium.h | 119 +++++++++ > drivers/net/phy/mdio-octeon.c | 280 ++------------------- > drivers/net/phy/mdio-thunder.c | 154 ++++++++++++ > 8 files changed, 535 insertions(+), 281 deletions(-) > create mode 100644 drivers/net/phy/mdio-cavium.c > create mode 100644 drivers/net/phy/mdio-cavium.h > create mode 100644 drivers/net/phy/mdio-thunder.c >