Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428AbcCLG1E (ORCPT ); Sat, 12 Mar 2016 01:27:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45325 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcCLG1A (ORCPT ); Sat, 12 Mar 2016 01:27:00 -0500 Date: Fri, 11 Mar 2016 22:26:58 -0800 From: Greg Kroah-Hartman To: "Dilger, Andreas" Cc: James Simmons , "devel@driverdev.osuosl.org" , "Drokin, Oleg" , Linux Kernel Mailing List , Lustre Development List Subject: Re: [lustre-devel] [PATCH 07/10] staging: lustre: cleanup comment style for lnet selftest Message-ID: <20160312062658.GA27424@kroah.com> References: <1457746191-27981-1-git-send-email-jsimmons@infradead.org> <1457746191-27981-8-git-send-email-jsimmons@infradead.org> <20160312062400.GA13693@kroah.com> <20160312062532.GA20558@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160312062532.GA20558@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2385 Lines: 52 On Fri, Mar 11, 2016 at 10:25:32PM -0800, Greg Kroah-Hartman wrote: > On Fri, Mar 11, 2016 at 10:24:00PM -0800, Greg Kroah-Hartman wrote: > > On Sat, Mar 12, 2016 at 01:39:01AM +0000, Dilger, Andreas wrote: > > > On 2016/03/11, 18:29, "lustre-devel on behalf of James Simmons" > > > > > jsimmons@infradead.org> wrote: > > > > > > >Apply a consistent style for comments in the lnet selftest > > > >code. > > > > > > > >Signed-off-by: James Simmons > > > >--- > > > > drivers/staging/lustre/lnet/selftest/brw_test.c | 8 ++-- > > > > drivers/staging/lustre/lnet/selftest/conctl.c | 50 > > > >+++++++++++----------- > > > > drivers/staging/lustre/lnet/selftest/conrpc.c | 23 +++++----- > > > > drivers/staging/lustre/lnet/selftest/console.c | 11 +++-- > > > > drivers/staging/lustre/lnet/selftest/framework.c | 20 ++++---- > > > > drivers/staging/lustre/lnet/selftest/ping_test.c | 2 +- > > > > drivers/staging/lustre/lnet/selftest/rpc.c | 46 > > > >++++++++++---------- > > > > drivers/staging/lustre/lnet/selftest/rpc.h | 2 +- > > > > drivers/staging/lustre/lnet/selftest/selftest.h | 3 +- > > > > drivers/staging/lustre/lnet/selftest/timer.c | 6 +- > > > > 10 files changed, 87 insertions(+), 84 deletions(-) > > > > > > > >diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c > > > >b/drivers/staging/lustre/lnet/selftest/brw_test.c > > > >index eebc924..6ac4d02 100644 > > > >--- a/drivers/staging/lustre/lnet/selftest/brw_test.c > > > >+++ b/drivers/staging/lustre/lnet/selftest/brw_test.c > > > >@@ -86,7 +86,7 @@ brw_client_init(sfw_test_instance_t *tsi) > > > > opc = breq->blk_opc; > > > > flags = breq->blk_flags; > > > > npg = breq->blk_npg; > > > >- /* > > > >+ /** > > > > * NB: this is not going to work for variable page size, > > > > * but we have to keep it for compatibility > > > > */ > > > > > > The "/**" comment opener is only for header comment blocks that > > > have markup in them. I don't think that is kernel style for > > > normal multi-line comments in the code. > > > > Yes, that is correct. James, can you fix this up and resend this > > series? > > Sorry, I meant the series from this patch onward. I've applied the > first 6. Make that just this patch, the ones after this applied just fine.